8000 FWT-45 adding Multiple Actually Dangerous Commits (Multi ADC Support) by tmb5932 · Pull Request #108 · RIT-EVT/EVT-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

FWT-45 adding Multiple Actually Dangerous Commits (Multi ADC Support) #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 115 commits into from
Dec 6, 2024
Merged

FWT-45 adding Multiple Actually Dangerous Commits (Multi ADC Support) #108

merged 115 commits into from
Dec 6, 2024

Conversation

tmb5932
Copy link
Contributor
@tmb5932 tmb5932 commented Sep 28, 2024 •
edited
Loading

Super cool really cool working multi adc for F4xx. Also made F4xx single adc work properly, as apparently it was broken before 👎

@tmb5932
Added new variable "adcPeriph" to adc class, so you can now choose th…
f7028f6 
…e adc to use. Made it an enum, so depending on if you are using f4xx or f3xx you can have different options.
@tmb5932
Added new method along with define statements to create a single uint…
ff87ea2 
…32_t that contains the channel as well as the ADC peripherals it supports (1, 2, and/or 3).

Added hard fault if the channel does not support the peripheral
@tmb5932
Updated ADC f4 to support multiple ADC's simultaneously (In theory)
0cd6678
@tmb5932
Fixed where default value was assigned
206a267
@tmb5932
fixed misplaced comments
ee190f8
@tmb5932 tmb5932 requested a review from mjh9585 September 28, 2024 16:57
@tmb5932 tmb5932 changed the title FWT-45 Support for Multiple Actually Dumb Commits (Multi ADC) FWT-45 adding Multiple Actually Dangerous Commits (Multi ADC Support) Sep 28, 2024
mjh9585
mjh9585 requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor
@mjh9585 mjh9585 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything obvious that is causing your issue, but maybe using a struct for each ADC will better distinguish between the ADCs and fix your issue in the process.

tmb5932 and others added 17 commits October 2, 2024 22:59
@tmb5932
Made it initializer list
e574c37
@tmb5932
Created struct to store each adc state information
e4971e3
@tmb5932
swapped over to using the struct. Still has old code, just commented out
2771124
@tmb5932
added dummy pin so that the pin array isnt initialized to all PA_0.
72a569d
@tmb5932
Testing alterations to multiadc sample. will be reverted when im done
80fd520
@tmb5932
added default values to the typedef struct. also am testing using 1 r…
ebcb3ce 
…ank var and 1 buffer
@tmb5932
Trying to make it work...
97d8d79
@tmb5932
Single adc works with single channel... Multi adc works, BUT only if …
bde81b0 
…its one 1 channel per adc
@tmb5932
MULTI & SINGLE WORK WITH 1 CHANNEL PER ADC
c08692b
@tmb5932
so it will build on github
c9b4dbf
Applied Formatting Changes During GitHub Build
ff878a1
@tmb5932
CubeIDE certified code... Doesnt work. but progress towards DMA Multi…
3e1ec95 
… ADC
@tmb5932
Merge remote-tracking branch 'origin/feature/tmb5932/MultiADC' into f…
e73ce50 
…eature/tmb5932/MultiADC

# Conflicts:
#	include/core/io/platform/f4xx/ADCf4xx.hpp
#	src/core/io/platform/f4xx/ADCf4xx.cpp
Applied Formatting Changes During GitHub Build
047f971
@tmb5932
SINGLE ADC WORKS!!!
63025d9
@tmb5932
Merge remote-tracking branch 'origin/feature/tmb5932/MultiADC' into f…
8a73d05 
…eature/tmb5932/MultiADC

# Conflicts:
#	src/core/io/platform/f4xx/ADCf4xx.cpp
Applied Formatting Changes During GitHub Build
08502cb
tmb5932 and others added 13 commits November 9, 2024 20:00
@tmb5932 tmb5932 requested a review from mjmagee991 November 12, 2024 01:29
Ethan-Caracoglia
Ethan-Caracoglia approved these changes Nov 13, 2024
View reviewed changes
Copy link
@Ethan-Caracoglia Ethan-Caracoglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes make sense and look good

@tmb5932
Copy link
Contributor Author
tmb5932 commented Nov 15, 2024

Just tested f4 and f3 adc single and multi (tested with diff combos all the way up to all 3 adc periphs with 3 channels on each), and everything works. Helldog saw it 👨‍🍳

mjmagee991
mjmagee991 approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor
@mjmagee991 mjmagee991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 little details

mjh9585
mjh9585 approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor
@mjh9585 mjh9585 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just a few little things.

@tmb5932 tmb5932 merged commit 8429056 into main Dec 6, 2024
1 check passed
@tmb5932 tmb5932 deleted the feature/tmb5932/MultiADC branch December 6, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjmagee991 mjmagee991 mjmagee991 approved these changes

@mjh9585 mjh9585 mjh9585 approved these changes

@Ethan-Caracoglia Ethan-Caracoglia Ethan-Caracoglia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmb5932 @mjmagee991 @mjh9585 @Ethan-Caracoglia
0