8000 Enable --transducer extension for ROCm by hubertlu-tw · Pull Request #88 · ROCm/apex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enable --transducer extension for ROCm #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 8, 2022
Merged

Enable --transducer extension for ROCm #88

merged 5 commits into from
Sep 8, 2022

Conversation

hubertlu-tw
Copy link

No description provided.

@hubertlu-tw hubertlu-tw self-assigned this Aug 23, 2022
@hubertlu-tw
Copy link
Author

There are five transducer extension unit tests skipped on ROCm. Please refer to #89 for the details.

  • test_transducer_joint_pack_relu_dropout (test_transducer_joint.TransducerJointTest)
  • test_transducer_joint_relu_dropout (test_transducer_joint.TransducerJointTest)
  • test_transducer_joint_vec_pack_relu_dropout (test_transducer_joint.TransducerJointTest)
  • test_transducer_joint_vec_relu_dropout (test_transducer_joint.TransducerJointTest)
  • test_transducer_joint_pack_relu (test_transducer_joint.TransducerJointTest)

@hubertlu-tw
Copy link
Author

jenkins: retest this please

1 similar comment
@hubertlu-tw
Copy link
Author

jenkins: retest this please

@hubertlu-tw
Copy link
Author

jenkins: retest this please

pruthvistony
pruthvistony previously approved these changes Aug 30, 2022
View reviewed changes
Copy link
@pruthvistony pruthvistony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look OK to me.
However better to wait for @jithunnair-amd to also have a look.

jithunnair-amd
jithunnair-amd reviewed Aug 30, 2022
View reviewed changes
@jithunnair-amd
Copy link
Collaborator

test_transducer unit test results:

----------------------------------------------------------------------
Ran 17 tests in 5.940s

OK (skipped=6)

@jithunnair-amd jithunnair-amd merged commit ae5ca67 into master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jithunnair-amd jithunnair-amd jithunnair-amd approved these changes

@pruthvistony pruthvistony pruthvistony left review comments

Assignees

@hubertlu-tw hubertlu-tw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hubertlu-tw @jithunnair-amd @pruthvistony
0