8000 Changing install script to default to hipcc by saadrahim · Pull Request #110 · ROCm/rocThrust · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Changing install script to default to hipcc #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 25, 2020

Conversation

saadrahim
Copy link
Member

No description provided.

@saadrahim saadrahim requested review from eidenyoshida and amdkila May 22, 2020 21:02
amdkila
amdkila previously approved these changes May 22, 2020
@saadrahim saadrahim requested a review from amdkila May 25, 2020 21:36
@saadrahim saadrahim dismissed amdkila’s stale review May 25, 2020 21:36

lot's of changes

@saadrahim
Copy link
Member Author

New review please guys due to lots of changes

Copy link
Collaborator
@eidenyoshida eidenyoshida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, wait for a CI pass

@saadrahim
Copy link
Member Author

Passing the compilation stage should be sufficient for this PR.

@saadrahim saadrahim merged commit f09291d into ROCm:master-rocm-3.5 May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0