8000 Update google benchmark version by umfranzw · Pull Request #545 · ROCm/rocThrust · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update google benchmark version #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

Update google benchmark version #545

merged 1 commit into from
May 16, 2025

Conversation

umfranzw
Copy link
Collaborator
@umfranzw umfranzw commented May 8, 2025

We are now using some newer google benchmark features that are not present in 1.8.0. Update the cmake dependencies file to pull version 1.9.0.

@umfranzw umfranzw requested a review from NguyenNhuDi May 8, 2025 14:37
NguyenNhuDi
NguyenNhuDi approved these changes May 8, 2025 •
edited
Loading
View reviewed changes
NguyenNhuDi
NguyenNhuDi approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor
@NguyenNhuDi NguyenNhuDi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. But maybe it's worthwhile to update the changelog as well. I think there is a change in the default units displayed in "console" mode when going from version 1.8.0 to version 1.9.0 (MB/s, GB/s, TB/s to Mi/s, Gi/s, Ti/s) .

@umfranzw
Update google benchmark version
20014ff 
We are now using some newer google benchmark features that are
not present in 1.8.0. Update the cmake dependencies file to
pull version 1.9.0.
@umfranzw umfranzw force-pushed the update_gbench_version branch from 2baa844 to 20014ff Compare May 9, 2025 19:23
@umfranzw umfranzw requested a review from a team as a code owner May 9, 2025 19:23
@umfranzw
Copy link
Collaborator Author
umfranzw commented May 9, 2025

Thanks @NguyenNhuDi - I've added a note about this to the changelog.

@umfranzw umfranzw requested a review from NguyenNhuDi May 9, 2025 19:24
NguyenNhuDi
NguyenNhuDi approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor
@NguyenNhuDi NguyenNhuDi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks Wayne

@umfranzw umfranzw merged commit cf22cb3 into ROCm:develop May 16, 2025
5 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleytsang-amd stanleytsang-amd stanleytsang-amd approved these changes

@NguyenNhuDi NguyenNhuDi NguyenNhuDi approved these changes

@spolifroni-amd spolifroni-amd spolifroni-amd approved these changes

@RobsonRLemos RobsonRLemos Awaiting requested review from RobsonRLemos RobsonRLemos is a code owner

@lawruble13 lawruble13 Awaiting requested review from lawruble13 lawruble13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@umfranzw @stanleytsang-amd @NguyenNhuDi @spolifroni-amd
0