8000 Update PC sampling doc by feizheng10 · Pull Request #798 · ROCm/rocprofiler-compute · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update PC sampling doc #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 14, 2025
Merged

Update PC sampling doc #798

merged 9 commits into from
Jul 14, 2025

Conversation

feizheng10
Copy link
Contributor
@feizheng10 feizheng10 commented Jul 8, 2025 •
edited
Loading

rocprofiler-compute Pull Request

Related Issue

  • Closes ROCDOC-1826

What type of PR is this? (check all that apply)

  • Bug Fix
  • Cherry Pick
  • Continuous Integration
  • Documentation Update
  • Feature
  • Optimization
  • Refactor
  • Other (please specify)

Technical Details

Have you added or updated tests to validate functionality?

  • Yes
  • No - does not apply to this PR

Added / Updated documentation?

  • [Y] Yes
  • No - does not apply to this PR

Have you updated CHANGELOG?

  • Yes
  • No - does not apply to this PR

@feizheng10 feizheng10 requested review from prbasyal-amd and a team as code owners July 8, 2025 23:00
cfallows-amd
cfallows-amd reviewed Jul 9, 2025
View reviewed changes
8000
vedithal-amd
vedithal-amd requested changes Jul 9, 2025
View reviewed changes
@feizheng10 feizheng10 requested a review from vedithal-amd July 9, 2025 18:00
prbasyal-amd
prbasyal-amd approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor
@prbasyal-amd prbasyal-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image loading error and formatting fixed. Rest LGTM

@feizheng10 feizheng10 merged commit 78c1898 into ROCm:develop Jul 14, 2025
5 checks passed
@feizheng10 feizheng10 deleted the pc_sampling_doc_update branch July 14, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfallows-amd cfallows-amd cfallows-amd left review comments

@prbasyal-amd prbasyal-amd prbasyal-amd approved these changes

@coleramos425 coleramos425 Awaiting requested review from coleramos425

@xuchen-amd xuchen-amd Awaiting requested review from xuchen-amd

@ywang103-amd ywang103-amd Awaiting requested review from ywang103-amd

@jamessiddeley-amd jamessiddeley-amd Awaiting requested review from jamessiddeley-amd

@vedithal-amd vedithal-amd Awaiting requested review from vedithal-amd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@feizheng10 @cfallows-amd @prbasyal-amd @vedithal-amd
0