Improving build time by removing the gfx11xx and host code from rccl_float8.h #1789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenkaidu
approved these changes
Jul 2, 2025
thananon
reviewed
Jul 8, 2025
thananon
reviewed
Jul 8, 2025
thananon
reviewed
Jul 8, 2025
thananon
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Do not mention proprietary info or link to internal work items in this PR.
Work item: "Internal", or link to GitHub issue (if applicable).
SWDEV-539929
What were the changes?
Removing the host side and gfx11 from OCP type check.
Why were the changes made?
The build time overhead is due to those specific architectures when the build includes all architectures (i.e., without -l).
How was the outcome achieved?
We achieved the build time reduction by excluding certain architectures from the build.
Additional Documentation:
What else should the reviewer know?
Approval Checklist
Do not approve until these items are satisfied.