[BUILD] Use fmt-header instead of libfmt #1791
Open
+8
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11491ed to
0b01f29
Compare
thananon
approved these changes
Jul 7, 2025
BertanDogancay
approved these changes
Jul 7, 2025
mustafabar
reviewed
Jul 7, 2025
| @@ -10,6 +10,9 @@ | |||
| #include <chrono> | |||
| #include <cstdint> | |||
| #include <deque> | |||
| #ifndef FMT_HEADER_ONLY | |||
| #define FMT_HEADER_ONLY 1 | |||
There was a problem hiding this comment.
What is this for? Can you add a comment if this is needed?
There was a problem hiding this comment.
FMT docs advise using this FMT_HEADER_ONLY macro to enable header-only mode. However, if we do not guard this, it throws a pre-definition warning. I thought we could keep this guard if some systems have an older FMT that does not pre-include this macro.
gpinkert
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Work item:
Internal
What were the changes?
Replaced libfmt.so dependency with fmt-header
Why were the changes made?
#1732 introduced a RCCL dependency on
libfmt.so. This PR switches to using fmt-header.Approval Checklist
Do not approve until these items are satisfied.