8000 Develop - Merge to TOT Master by kiritigowda · Pull Request #189 · ROCm/rpp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Develop - Merge to TOT Master #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 23, 2023
Merged

Develop - Merge to TOT Master #189

merged 10 commits into from
Aug 23, 2023

Conversation

kiritigowda
Copy link
Collaborator

No description provided.

LakshmiKumar23 and others added 4 commits August 10, 2023 14:20
@LakshmiKumar23 @dependabot
CMakeLists - AMD GPU Target Updates (#186)
f53e3fc 
* Bump rocm-docs-core from 0.18.4 to 0.20.0 in /docs/.sphinx (#182)

Bumps [rocm-docs-core](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.18.4 to 0.20.0.
- [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases)
- [Changelog](https://github.com/RadeonOpenCompute/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v0.18.4...v0.20.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* mi300x enabelment for rpp

* build fix for non mi300 gpus

* comment - changes

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@r-abishek @dependabot @sampath1117
Testing help update (#187)
8614792 
* Bump rocm-docs-core from 0.18.4 to 0.20.0 in /docs/.sphinx (#182)

Bumps [rocm-docs-core](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.18.4 to 0.20.0.
- [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases)
- [Changelog](https://github.com/RadeonOpenCompute/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v0.18.4...v0.20.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* added maps for supported functionalities in unique functions test suites for HOST and HIP

* minor change

* added help when number of arguments are less than required arguments

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: sampath1117 <sampath.rachumallu@multicorewareinc.com>
@raramakr @dependabot
SWDEV-416168 - Add rocm-core dependency to rpp package (#188)
bb14d60 
* Bump rocm-docs-core from 0.18.4 to 0.20.0 in /docs/.sphinx (#182)

Bumps [rocm-docs-core](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.18.4 to 0.20.0.
- [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases)
- [Changelog](https://github.com/RadeonOpenCompute/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v0.18.4...v0.20.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* SWDEV-416168 - Add rocm-core dependency to rpp package

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@kiritigowda
CMakeLists - Version Update
d2984ef 
Update to 1.3.0
@kiritigowda kiritigowda changed the title Develop - Merge to TOT Master WIP:Develop - Merge to TOT Master Aug 10, 2023
@kiritigowda
CTest - Test infrastructure & Initial Unit Tests (#184)
8398ee2 
* CTest - Added

* CTest - HIP Updates
@kiritigowda kiritigowda requested a review from r-abishek August 18, 2023 19:09
@kiritigowda kiritigowda added the enhancement New feature or request label Aug 18, 2023
@kiritigowda kiritigowda changed the title WIP:Develop - Merge to TOT Master Develop - Merge to TOT Master Aug 18, 2023
rrawther
rrawther approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor
@rrawther rrawther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paveltc to run tests on this

@kiritigowda @raramakr
SWDEV-416168 - Add rocm-core dependency to rpp package (#193)
ada4e37 
Co-authored-by: Ranjith Ramakrishnan <Ranjith.Ramakrishnan@amd.com>
@paveltc
Copy link
Contributor
paveltc commented Aug 21, 2023

@rrawther Do you know what changes are expected from this PR? Anything actually touching the RPP kernels and their functionality?

@kiritigowda
Jenkins - Add CTest (#194)
b7efd05 
* Jenkins - Add Test

* Jenkins - Test output
@kiritigowda
Copy link
Collaborator Author

@paveltc - Mostly unit test updates

@paveltc
Copy link
Contributor
paveltc commented Aug 21, 2023

@kiritigowda But do you know if there is any possibility that the unit tests will give different output? Or is it fine to just make sure that the unit tests run fine?

@paveltc
Copy link
Contributor
paveltc commented Aug 21, 2023

@kiritigowda The HIP unit tests crash the system. Can you try to run them on your end to see if you can reproduce it?

@kiritigowda
Copy link
Collaborator Author

@paveltc I am noticing a few failures on this PR. @r-abishek below are some of the tests that are failing since your PR #187. Can you take a look at this?


test 22
      Start 22: rpp_hip_test_f16_13

22: Test command: /var/jenkins_home/workspace/main_Short-GPUOpen_rpp_develop/VVPGtw4Xe/rpp/build/release/utilities/rpp-unittests/rpp_hip_test/uniqueFunctionalities_hip "1" "0"
22: Test timeout computed to be: 1500
22: 
22: test_case 0 supports only 0 ip_bitDepth
22: ip_bitDepth = 1
22: test_case = 0
22: This functionality sub-type of tensor_transpose doesn't yet exist in RPP
22/27 Test #22: rpp_hip_test_f16_13 ..............***Failed    0.97 sec
test 23
      Start 23: rpp_hip_test_f32_14

23: Test command: /var/jenkins_home/workspace/main_Short-GPUOpen_rpp_develop/VVPGtw4Xe/rpp/build/release/utilities/rpp-unittests/rpp_hip_test/uniqueFunctionalities_hip "2" "0"
23: Test timeout computed to be: 1500
23: 
23: test_case 0 supports only 0 ip_bitDepth
23: ip_bitDepth = 2
23: test_case = 0
23: This functionality sub-type of tensor_transpose doesn't yet exist in RPP
23/27 Test #23: rpp_hip_test_f32_14 ..............***Failed    1.04 sec
test 24
      Start 24: rpp_hip_test_u08_f16_15

24: Test command: /var/jenkins_home/workspace/main_Short-GPUOpen_rpp_develop/VVPGtw4Xe/rpp/build/release/utilities/rpp-unittests/rpp_hip_test/uniqueFunctionalities_hip "3" "0"
24: Test timeout computed to be: 1500
24: 
24: test_case 0 supports only 0 ip_bitDepth
24: ip_bitDepth = 3
24: test_case = 0
24: This functionality sub-type of tensor_transpose doesn't yet exist in RPP
24/27 Test #24: rpp_hip_test_u08_f16_15 ..........***Failed    0.97 sec
test 25
      Start 25: rpp_hip_test_u08_f32_16

25: Test command: /var/jenkins_home/workspace/main_Short-GPUOpen_rpp_develop/VVPGtw4Xe/rpp/build/release/utilities/rpp-unittests/rpp_hip_test/uniqueFunctionalities_hip "4" "0"
25: Test timeout computed to be: 1500
25: 
25: test_case 0 supports only 0 ip_bitDepth
25: ip_bitDepth = 4
25: test_case = 0
25: This functionality sub-type of tensor_transpose doesn't yet exist in RPP
25/27 Test #25: rpp_hip_test_u08_f32_16 ..........***Failed    1.09 sec
test 26
      Start 26: rpp_hip_test_i08_17

26: Test command: /var/jenkins_home/workspace/main_Short-GPUOpen_rpp_develop/VVPGtw4Xe/rpp/build/release/utilities/rpp-unittests/rpp_hip_test/uniqueFunctionalities_hip "5" "0"
26: Test timeout computed to be: 1500
26: 
26: test_case 0 supports only 0 ip_bitDepth
26: ip_bitDepth = 5
26: test_case = 0
26: This functionality sub-type of tensor_transpose doesn't yet exist in RPP
26/27 Test #26: rpp_hip_test_i08_17 ..............***Failed    1.04 sec
test 27
      Start 27: rpp_hip_test_u08_i08_18

27: Test command: /var/jenkins_home/workspace/main_Short-GPUOpen_rpp_develop/VVPGtw4Xe/rpp/build/release/utilities/rpp-unittests/rpp_hip_test/uniqueFunctionalities_hip "6" "0"
27: Test timeout computed to be: 1500
27: 
27: test_case 0 supports only 0 ip_bitDepth
27: ip_bitDepth = 6
27: test_case = 0
27: This functionality sub-type of tensor_transpose doesn't yet exist in RPP
27/27 Test #27: rpp_hip_test_u08_i08_18 ..........***Failed    0.96 sec

78% tests passed, 6 tests failed out of 27

Total Test time (real) =  25.48 sec

The following tests FAILED:
	 22 - rpp_hip_test_f16_13 (Failed)
	 23 - rpp_hip_test_f32_14 (Failed)
	 24 - rpp_hip_test_u08_f16_15 (Failed)
	 25 - rpp_hip_test_u08_f32_16 (Failed)
	 26 - rpp_hip_test_i08_17 (Failed)
	 27 - rpp_hip_test_u08_i08_18 (Failed)
Errors while running CTest

@kiritigowda
Copy link
Collaborator Author

@r-abishek - pr #187 turned off 6 tests - can you check on this?

make test
Running tests...
Test project /home/kiriti/develop/rpp-kiriti/build
Start 1: rpp_cpu_test_u08_01
1/27 Test #1: rpp_cpu_test_u08_01 .............. Passed 13.65 sec
Start 2: rpp_cpu_test_u08_02
2/27 Test #2: rpp_cpu_test_u08_02 .............. Passed 0.09 sec
Start 3: rpp_cpu_test_u08_03
3/27 Test #3: rpp_cpu_test_u08_03 .............. Passed 0.08 sec
Start 4: rpp_cpu_test_u08_04
4/27 Test #4: rpp_cpu_test_u08_04 .............. Passed 0.09 sec
Start 5: rpp_cpu_test_u08_05
5/27 Test #5: rpp_cpu_test_u08_05 .............. Passed 0.10 sec
Start 6: rpp_cpu_test_u08_06
6/27 Test #6: rpp_cpu_test_u08_06 .............. Passed 0.09 sec
Start 7: rpp_cpu_test_u08_07
7/27 Test #7: rpp_cpu_test_u08_07 .............. Passed 0.07 sec
Start 8: rpp_cpu_test_u08_08
8/27 Test #8: rpp_cpu_test_u08_08 .............. Passed 0.07 sec
Start 9: rpp_cpu_test_u08_09
9/27 Test #9: rpp_cpu_test_u08_09 .............. Passed 0.07 sec
Start 10: rpp_cpu_test_u08_11
10/27 Test #10: rpp_cpu_test_u08_11 .............. Passed 0.07 sec
Start 11: rpp_cpu_test_u08_12
11/27 Test #11: rpp_cpu_test_u08_12 .............. Passed 0.07 sec
Start 12: rpp_cpu_test_f16_13
12/27 Test #12: rpp_cpu_test_f16_13 .............. Passed 0.07 sec
Start 13: rpp_cpu_test_f32_14
13/27 Test #13: rpp_cpu_test_f32_14 .............. Passed 0.07 sec
Start 14: rpp_cpu_test_i08_17
14/27 Test #14: rpp_cpu_test_i08_17 .............. Passed 0.07 sec
Start 15: rpp_hip_test_u08_01
15/27 Test #15: rpp_hip_test_u08_01 .............. Passed 103.52 sec
Start 16: rpp_hip_test_u08_02
16/27 Test #16: rpp_hip_test_u08_02 .............. Passed 0.40 sec
Start 17: rpp_hip_test_u08_03
17/27 Test #17: rpp_hip_test_u08_03 .............. Passed 0.41 sec
Start 18: rpp_hip_test_u08_04
18/27 Test #18: rpp_hip_test_u08_04 .............. Passed 0.43 sec
Start 19: rpp_hip_test_u08_05
19/27 Test #19: rpp_hip_test_u08_05 .............. Passed 0.40 sec
Start 20: rpp_hip_test_u08_06
20/27 Test #20: rpp_hip_test_u08_06 .............. Passed 0.38 sec
Start 21: rpp_hip_test_u08_09
21/27 Test #21: rpp_hip_test_u08_09 .............. Passed 0.35 sec
Start 22: rpp_hip_test_f16_13
22/27 Test #22: rpp_hip_test_f16_13 .............. Passed 0.40 sec
Start 23: rpp_hip_test_f32_14
23/27 Test #23: rpp_hip_test_f32_14 .............. Passed 0.40 sec
Start 24: rpp_hip_test_u08_f16_15
24/27 Test #24: rpp_hip_test_u08_f16_15 .......... Passed 0.39 sec
Start 25: rpp_hip_test_u08_f32_16
25/27 Test #25: rpp_hip_test_u08_f32_16 .......... Passed 0.36 sec
Start 26: rpp_hip_test_i08_17
26/27 Test #26: rpp_hip_test_i08_17 .............. Passed 0.38 sec
Start 27: rpp_hip_test_u08_i08_18
27/27 Test #27: rpp_hip_test_u08_i08_18 .......... Passed 0.38 sec

100% tests passed, 0 tests failed out of 27

Total Test time (real) = 122.86 sec

@paveltc
Copy link
Contributor
paveltc commented Aug 22, 2023 •
edited
Loading

@r-abishek @kiritigowda The crash occur on the following HIP unit test:
./BatchPD_hip_pln1 /home/svcbuild/rpp-pr189/rpp/utilities/rpp-unittests/HIP_NEW/../TEST_IMAGES/three_images_224x224_src1 /home/svcbuild/rpp-pr189/rpp/utilities/rpp-unittests/HIP_NEW/../TEST_IMAGES/three_images_224x224_src2 /home/svcbuild/rpp-pr189/rpp/utilities/rpp-unittests/HIP_NEW/../OUTPUT_IMAGES_HIP_NEW/rpp_hip_pln1_advanced_augmentations 0 0 32 0

Update
I just checked and this also happens on the master branch.

@kiritigowda
Copy link
Collaborator Author

@paveltc can we merge this pr then as it's not related to the failure? @r-abishek can we fix the tests that were turned off?

@r-abishek
Copy link
Member

@kiritigowda Yes, this rpp_hip_pln1_advanced_augmentations 0 0 32 0 is a separate issue not stemming from PR#187. @sampath1117 Could we issue a PR to develop with the minor change?

@kiritigowda
Copy link
Collaborator Author

@paveltc - This PR currently passes all CTest - can we merge this?

make test
Running tests...
      Start  1: rpp_cpu_test_u08_01
 1/24 Test  #1: rpp_cpu_test_u08_01 ..............   Passed   13.79 sec
      Start  2: rpp_cpu_test_u08_02
 2/24 Test  #2: rpp_cpu_test_u08_02 ..............   Passed    0.10 sec
      Start  3: rpp_cpu_test_u08_03
 3/24 Test  #3: rpp_cpu_test_u08_03 ..............   Passed    0.07 sec
      Start  4: rpp_cpu_test_u08_04
 4/24 Test  #4: rpp_cpu_test_u08_04 ..............   Passed    0.07 sec
      Start  5: rpp_cpu_test_u08_05
 5/24 Test  #5: rpp_cpu_test_u08_05 ..............   Passed    0.07 sec
      Start  6: rpp_cpu_test_u08_06
 6/24 Test  #6: rpp_cpu_test_u08_06 ..............   Passed    0.09 sec
      Start  7: rpp_cpu_test_u08_07
 7/24 Test  #7: rpp_cpu_test_u08_07 ..............   Passed    0.07 sec
      Start  8: rpp_cpu_test_u08_08
 8/24 Test  #8: rpp_cpu_test_u08_08 ..............   Passed    0.09 sec
      Start  9: rpp_cpu_test_u08_09
 9/24 Test  #9: rpp_cpu_test_u08_09 ..............   Passed    0.07 sec
      Start 10: rpp_cpu_test_u08_11
10/24 Test #10: rpp_cpu_test_u08_11 ..............   Passed    0.07 sec
      Start 11: rpp_cpu_test_u08_12
11/24 Test #11: rpp_cpu_test_u08_12 ..............   Passed    0.07 sec
      Start 12: rpp_cpu_test_f16_13
12/24 Test #12: rpp_cpu_test_f16_13 ..............   Passed    0.07 sec
      Start 13: rpp_cpu_test_f32_14
13/24 Test #13: rpp_cpu_test_f32_14 ..............   Passed    0.07 sec
      Start 14: rpp_cpu_test_i08_15
14/24 Test #14: rpp_cpu_test_i08_15 ..............   Passed    0.07 sec
      Start 15: rpp_hip_test_u08_01
15/24 Test #15: rpp_hip_test_u08_01 ..............   Passed  102.75 sec
      Start 16: rpp_hip_test_u08_02
16/24 Test #16: rpp_hip_test_u08_02 ..............   Passed    0.42 sec
      Start 17: rpp_hip_test_u08_03
17/24 Test #17: rpp_hip_test_u08_03 ..............   Passed    0.35 sec
      Start 18: rpp_hip_test_u08_04
18/24 Test #18: rpp_hip_test_u08_04 ..............   Passed    0.41 sec
      Start 19: rpp_hip_test_u08_05
19/24 Test #19: rpp_hip_test_u08_05 ..............   Passed    0.36 sec
      Start 20: rpp_hip_test_u08_06
20/24 Test #20: rpp_hip_test_u08_06 ..............   Passed    0.38 sec
      Start 21: rpp_hip_test_u08_07
21/24 Test #21: rpp_hip_test_u08_07 ..............   Passed    0.37 sec
      Start 22: rpp_hip_test_f16_08
22/24 Test #22: rpp_hip_test_f16_08 ..............   Passed    0.38 sec
      Start 23: rpp_hip_test_f32_09
23/24 Test #23: rpp_hip_test_f32_09 ..............   Passed    0.40 sec
      Start 24: rpp_hip_test_i08_10
24/24 Test #24: rpp_hip_test_i08_10 ..............   Passed    0.38 sec

100% tests passed, 0 tests failed out of 24

Total Test time (real) = 120.95 sec

@kiritigowda kiritigowda merged commit 2d767a1 into master Aug 23, 2023
@kiritigowda kiritigowda deleted the develop branch August 23, 2023 20:39
swetha097 pushed a commit to swetha097/rpp that referenced this pull request Sep 27, 2024
@r-abishek
Merge pull request ROCm#189 from snehaa8/sn/nsr_host_tensor
3f5aec6 
QA mode changes in audio test suite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrawther rrawther rrawther approved these changes

@r-abishek r-abishek Awaiting requested review from r-abishek

Assignees

@paveltc paveltc

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kiritigowda @paveltc @r-abishek @rrawther @LakshmiKumar23 @raramakr @sampath1117
0