Test Suite - Fixes #577
Open
Test Suite - Fixes #577
+28
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPP Voxel Test suite fixes
There was a problem hiding this comment.
Pull Request Overview
This PR refactors test grouping logic and standardizes error codes for unimplemented variants in the voxel test suite.
- Introduces
voxelAugmentationGroupMapand generalizesfunc_group_finder/process_layout/directory_name_generatorto accept a group map - Updates all HOST/HIP
runVoxelTests.pyandrunImageTests.pyto use the new grouping interface - Replaces
return -1withreturn RPP_ERROR_NOT_IMPLEMENTEDin C++ test binaries for unsupported cases
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| utilities/test_suite/common.py | Added voxelAugmentationGroupMap and refactored grouping functions to take a groupMap parameter |
| utilities/test_suite/HOST/runVoxelTests.py | Removed local func_group_finder and updated calls to process_layout with voxelAugmentationGroupMap |
| utilities/test_suite/HOST/runImageTests.py | Updated process_layout calls to pass ImageAugmentationGroupMap |
| utilities/test_suite/HOST/Tensor_voxel_host.cpp | Changed return -1 to RPP_ERROR_NOT_IMPLEMENTED for unimplemented test cases |
| utilities/test_suite/HIP/runVoxelTests.py | Removed duplicate func_group_finder and passed voxelAugmentationGroupMap to process_layout |
| utilities/test_suite/HIP/runImageTests.py | Updated most process_layout calls to pass ImageAugmentationGroupMap (one instance still uses the wrong variable) |
| utilities/test_suite/HIP/Tensor_voxel_hip.cpp | Changed return -1 to RPP_ERROR_NOT_IMPLEMENTED for unsupported variants |
Comments suppressed due to low confidence (2)
utilities/test_suite/common.py:140
- The new
voxelAugmentationGroupMapand its usage infunc_group_finderintroduce grouping logic that isn’t directly covered by existing tests. Add unit tests forfunc_group_finderwithvoxelAugmentationGroupMap, covering each group and edge cases.
voxelAugmentationGroupMap = {
utilities/test_suite/common.py:246
- Consider using
os.path.jointo build the destination path instead of manual string concatenation (e.g.,path + "/rpp_...") for better cross-platform compatibility.
def directory_name_generator(qaMode, affinity, layoutType, case, path, groupMap, func_group_finder):
| @@ -350,7 +350,7 @@ def rpp_test_suite_parser_and_validator(): | |||
| srcPath1 = inFilePath1 | |||
| srcPath2 = inFilePath2 | |||
| for layout in range(3): | |||
| dstPathTemp, logFileLayout = process_layout(layout, qaMode, case, dstPath, "hip", func_group_finder) | |||
| dstPathTemp, logFileLayout = process_layout(layout, qaMode, case, dstPath, "hip", imageAugmentationMap, func_group_finder) | |||
There was a problem hiding this comment.
This call passes imageAugmentationMap instead of the intended ImageAugmentationGroupMap, which will cause grouping to break or a NameError. Update it to ImageAugmentationGroupMap to match the other invocations.
Suggested change
| dstPathTemp, logFileLayout = process_layout(layout, qaMode, case, dstPath, "hip", imageAugmentationMap, func_group_finder) | |
| dstPathTemp, logFileLayout = process_layout(layout, qaMode, case, dstPath, "hip", ImageAugmentationGroupMap, func_group_finder) |
Copilot uses AI. Check for mistakes.
rrawther
requested changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor PR to fix grouping in voxel unit tests and add appropriate return error code for variants not implemented
10000