8000 board.linux: Add pasword prompt variable by bauer-alex-174 · Pull Request #93 · Rahix/tbot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

board.linux: Add pasword prompt variable #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000
Merged
merged 1 commit into from
Apr 18, 2023
Merged

board.linux: Add pasword prompt variable #93

merged 1 commit into from
Apr 18, 2023

Conversation

bauer-alex-174
Copy link
Contributor

The expected value for password prompt was hardcoded ("assword: ") which results in an unability to login when the language is not set to English. This commit adds a new variable which is by default set to the previously hardcoded string, but allows the user to overwrite it on demand.

Copy link
Owner
@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution! I have one small request, please see my comment below.

@Rahix
Copy link
Owner
Rahix commented Apr 18, 2023

CI is failing, you need to run the black code formatter or just manually do the change you can see in the CI error log.

The expected value for password prompt was hardcoded ("assword: ")
which results in an unability to login when the language is not set
to English. This commit adds a new variable which is by default set
to the previously hardcoded string, but allows the user to overwrite
it on demand.

Signed-off-by: Alexander Späth <aspaeth@christ-es.de>
@bauer-alex-174
Copy link
Contributor Author

@Rahix I updated the PR

Copy link
Owner
@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks so much!

@Rahix Rahix merged commit b2758af into Rahix:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0