-
Notifications
You must be signed in to change notification settings - Fork 61
Add test addon to deploy rook based CephFS instance #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Effort was to test volsync with drenv, and hence adding a CephFS instance to drenv. Ideally this should be invoked form the regional-dr env file, which I used to test with locally. Just waiting to resolve volsync mover permission correctly before integrating this with the regional env. An example ocm-sample that was tested is here for reference. This required that the |
e8fc51a
to
4ec0eec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! it would be even better with self test.
Annotating the busybox-sample namespace did not work when I tried, it is the namespace I tried to add a namespace to the application, but in this case OCM removes it during I think we can solve this by adding the annotations in ramen on the manifestwork for the namespace, maybe only on k8s? For real clusters I don't think we should promote running as root, instead we should |
I did not add a self test because initially/originally the tests were intended for some components that were unstable. If we are adding tests to all addons, we could add a PVC create/delete test against CephFS as a test. |
10bf646
to
84789b5
Compare
Test added |
84789b5
to
87f4e30
Compare
87f4e30
to
7fc2b3d
Compare
7fc2b3d
to
c771660
Compare
... and required storage and snapshot classes to consume the same. Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
c771660
to
0f3ce34
Compare
@nirs I am done addressing comments that I think need addressing in this PR. I added a final commit to source from rook git instead of local copy of the resources. Added an issue that I found while testing, potentially a corner case as 2 runners need to process the same addon and in this part of the code at the same time, but noted here: #1386 |
0f3ce34
to
4875750
Compare
Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
4875750
to
f0d9185
Compare
... and required storage and snapshot classes to consume the same.