8000 Add test addon to deploy rook based CephFS instance by ShyamsundarR · Pull Request #1192 · RamenDR/ramen · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add test addon to deploy rook based CephFS instance #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2024

Conversation

ShyamsundarR
Copy link
Member

... and required storage and snapshot classes to consume the same.

@ShyamsundarR
Copy link
Member Author

Effort was to test volsync with drenv, and hence adding a CephFS instance to drenv.

Ideally this should be invoked form the regional-dr env file, which I used to test with locally. Just waiting to resolve volsync mover permission correctly before integrating this with the regional env.

An example ocm-sample that was tested is here for reference. This required that the busybox-sample namespace be annotated with kubectl annotate ns/busybox-sample volsync.backube/privileged-movers=true on both clusters for the movers to work.

@ShyamsundarR ShyamsundarR force-pushed the add-cephfs-volsync branch 2 times, most recently from e8fc51a to 4ec0eec Compare February 8, 2024 12:38
Copy link
Member
@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! it would be even better with self test.

@nirs
Copy link
Member
nirs commented Feb 21, 2024

An example ocm-sample that was tested is here for reference. This required that the busybox-sample namespace be annotated with kubectl annotate ns/busybox-sample volsync.backube/privileged-movers=true on both clusters for the movers to work.

Annotating the busybox-sample namespace did not work when I tried, it is the namespace
created on the hub. OCM does not copy the annotations from the hub namespace to the manged clusters.

I tried to add a namespace to the application, but in this case OCM removes it during
cleanup.

I think we can solve this by adding the annotations in ramen on the manifestwork for the namespace, maybe only on k8s?

For real clusters I don't think we should promote running as root, instead we should
confi 8000 gure replicationsource/destination with the right security context, copied from
the pod.

@ShyamsundarR
Copy link
Member Author

Nice! it would be even better with self test.

I did not add a self test because initially/originally the tests were intended for some components that were unstable. If we are adding tests to all addons, we could add a PVC create/delete test against CephFS as a test.

@ShyamsundarR ShyamsundarR force-pushed the add-cephfs-volsync branch 2 times, most recently from 10bf646 to 84789b5 Compare May 8, 2024 19:35
@ShyamsundarR
Copy link
Member Author

Nice! it would be even better with self test.

I did not add a self test because initially/originally the tests were intended for some components that were unstable. If we are adding tests to all addons, we could add a PVC create/delete test against CephFS as a test.

Test added

@ShyamsundarR ShyamsundarR force-pushed the add-cephfs-volsync branch from 84789b5 to 87f4e30 Compare May 8, 2024 19:39
@ShyamsundarR ShyamsundarR force-pushed the add-cephfs-volsync branch from 87f4e30 to 7fc2b3d Compare May 8, 2024 20:07
@ShyamsundarR ShyamsundarR force-pushed the add-cephfs-volsync branch from 7fc2b3d to c771660 Compare May 9, 2024 19:24
... and required storage and snapshot classes to consume
the same.

Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
@ShyamsundarR ShyamsundarR force-pushed the add-cephfs-volsync branch from c771660 to 0f3ce34 Compare May 9, 2024 19:29
@ShyamsundarR
Copy link
Member Author
ShyamsundarR commented May 9, 2024

@nirs I am done addressing comments that I think need addressing in this PR. I added a final commit to source from rook git instead of local copy of the resources.

Added an issue that I found while testing, potentially a corner case as 2 runners need to process the same addon and in this part of the code at the same time, but noted here: #1386

@ShyamsundarR ShyamsundarR force-pushed the add-cephfs-volsync branch from 0f3ce34 to 4875750 Compare May 9, 2024 19:36
Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
@ShyamsundarR ShyamsundarR force-pushed the add-cephfs-volsync branch from 4875750 to f0d9185 Compare May 9, 2024 19:57
@nirs nirs merged commit 7b8cf54 into RamenDR:main May 12, 2024
@ShyamsundarR ShyamsundarR deleted the add-cephfs-volsync branch November 22, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0