Enable and process GroupClass based replication #2030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e609d28 to
dbbea78
Compare
|
Next set of VRG Changes will be included in a separate PR.
@ShyamsundarR and @BenamarMk. This is ready for Review |
98555f4 to
85f0bba
Compare
ShyamsundarR
reviewed
Jul 2, 2025
| @@ -11,6 +11,7 @@ import ( | |||
| "time" | |||
|
|
|||
| volrep "github.com/csi-addons/kubernetes-csi-addons/api/replication.storage/v1alpha1" | |||
| groupsnapv1beta1 "github.com/kubernetes-csi/external-snapshotter/client/v8/apis/volumegroupsnapshot/v1beta1" | |||
There was a problem hiding this comment.
Needs an update post changes to the private VGS API: groupsnapv1beta1 "github.com/red-hat-storage/external-snapshotter/client/v8/apis/volumegroupsnapshot/v1beta1"
| vrClasses: vrClasses, | ||
| vsClasses: vsClasses, | ||
| vgrClasses: vgrClasses, | ||
| vgsClasses: vgsClasses, | ||
| }, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
deleteViewsForClasses should prune VGR and VSC class views.
| vrcID := getAsyncVRClassPeer(scName, cls[0], cl, sID, sIDcl, schedule) | ||
| vgrcID := getAsyncVGRClassPeer(scName, cls[0], cl, sID, sIDcl, schedule) | ||
|
|
||
| rID, grouping := isGroupingEnabledForReplication(vrcID, vgrcID) |
There was a problem hiding this comment.
This line (and function) can be replaced by the following:
grouping := rID != "" && rID == vgrcID (retain the output of getAsyncVRClassPeer in rID instead of vrcID)
| }, | ||
| }, | ||
| Spec: volrep.VolumeReplicationClassSpec{ | ||
| Provisioner: "sample2.csi.com", | ||
| Parameters: map[string]string{ | ||
| VRClassScheduleKey: "1m", | ||
| ReplicationClassScheduleKey: "1m", |
There was a problem hiding this comment.
We need some tests for grouping behavior here.
DRClusterConfig will be updated with VolumeGroupReplicationClasses and VolumeGroupSnapshotClasses Signed-off-by: rakeshgm <rakeshgm@redhat.com>
Signed-off-by: rakeshgm <rakeshgm@redhat.com>
remove references of ClusterClaims in the tests and rephrase the descriptions with DRClusterConfig Status Signed-off-by: rakeshgm <rakeshgm@redhat.com>
rename VolumeReplicationIDLabel to ReplicationIDLabel since this is now being used in VolumeGroupReplicationClass as well as VolumeReplicationClass Signed-off-by: rakeshgm <rakeshgm@redhat.com>
Signed-off-by: rakeshgm <rakeshgm@redhat.com>
enable grouping based on VolumeGroupReplicationClass. grouping is enabled if and only if replication id matches both volumeGroupRepliationClass and volumeReplicationClass which belong to the same storageClass with same storageID Signed-off-by: rakeshgm <rakeshgm@redhat.com>
since this key is now being used for VGRC and VRC, it makes sense to have a common name. The key is renamed to ReplicationClassScheduleKey Signed-off-by: rakeshgm <rakeshgm@redhat.com>
enable grouping based on VolumeGroupSnapshotClass. grouping is enabled if VGRC belongs to the same storageClass with the same storageID Signed-off-by: rakeshgm <rakeshgm@redhat.com>
Signed-off-by: rakeshgm <rakeshgm@redhat.com>
when DRPC is annotated for CG, udpate peerClass.grouping to true. This check is to ensure there is a backward comptability of drpc was already annotated Signed-off-by: rakeshgm <rakeshgm@redhat.com>
Signed-off-by: rakeshgm <rakeshgm@redhat.com>
Signed-off-by: rakeshgm <rakeshgm@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #2015, this changes includes