recipe: fixing possible concurrent map issue #2061
8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d7a990c to
8012373
Compare
raghavendra-talur
approved these changes
May 28, 2025
nirs
reviewed
May 29, 2025
| @@ -57,7 +58,7 @@ type VolumeReplicationGroupReconciler struct { | |||
| kubeObjects kubeobjects.RequestsManager | |||
| RateLimiter *workqueue.TypedRateLimiter[reconcile.Request] | |||
| veleroCRsAreWatched bool | |||
| recipeStatus map[string]*util.RecipeStatus | |||
| recipeRetries sync.Map | |||
There was a problem hiding this comment.
See comment in the other PR about sync.map.
There is a possible issue of concurrent map writes while using status. To solve the same, sync.Map is being used for the same. Signed-off-by: Annaraya Narasagond <annarayanarasagond@gmail.com>
8012373 to
b567a2f
Compare
ShyamsundarR
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a possible issue of concurrent map writes while using status. To solve the same, sync.Map is being used for the same.