8000 Private VGS API support by ELENAGER · Pull Request #2084 · RamenDR/ramen · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Private VGS API support #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 25, 2025
Merged

Private VGS API support #2084

merged 4 commits into from
Jun 25, 2025

Conversation

ELENAGER
Copy link
Member

This PR contains all the necessary changes in order to support private VGS API.

ELENAGER added 4 commits June 17, 2025 15:36
@ELENAGER
Add CRDs for private VGS API
2d1ce83 
Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>
@ELENAGER
Update go.mod for private VGS API
43cb02f 
Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>
@ELENAGER
Add roles for private VGS API
d38a10a 
Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>
@ELENAGER
Replace imports for private VGS API
358a8df 
Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>
@ShyamsundarR
Copy link
Member

@BenamarMk I was assuming upstream we would look at supporting both APIs. For example look at what is installed, or what the GVK for the corresponding VolumeGroupSnapshotClass is, and then use the same VolumeGroupSnapshot GVK API. Are you fine with just shifting to the private API and looking at supporting both APIs in the (near) future? (as this may impact migrations down the line).

@BenamarMk
Copy link
Member

@BenamarMk I was assuming upstream we would look at supporting both APIs. For example look at what is installed, or what the GVK for the corresponding VolumeGroupSnapshotClass is, and then use the same VolumeGroupSnapshot GVK API. Are you fine with just shifting to the private API and looking at supporting both APIs in the (near) future? (as this may impact migrations down the line).

@ShyamsundarR, that's fine, we can worry about it in the future. I was more concerned about the migration

ShyamsundarR
ShyamsundarR approved these changes Jun 25, 2025
View reviewed changes
Copy link
Member
@ShyamsundarR ShyamsundarR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ELENAGER At some point in the near future we would need to support both the Private and the Public API for VGS. This PR shifts it into the private version, but would help to have support for both.

@ShyamsundarR ShyamsundarR merged commit f696cc3 into RamenDR:main Jun 25, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShyamsundarR ShyamsundarR ShyamsundarR approved these changes

@BenamarMk B 52CA enamarMk BenamarMk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ELENAGER @ShyamsundarR @BenamarMk
0