Refactor labelling of CG PVCs based on PeerClass #2100
+60
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b7ba28 to
843fa5d
Compare
|
@ELENAGER please rebase to fix the CI errors. |
f1d1d1d to
3c9abd0
Compare
…roupreplications CRD Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>
…ly volumegroupsnapshots CRD Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>
…Rep PVC lists Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>
Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>
BenamarMk
reviewed
Jun 30, 2025
| return annotations[IsCGEnabledAnnotation] == "true" | ||
| // It checks whether the VolumeGroupReplication CRD is installed. | ||
| // This condition must be true for VolRep CG protection to be considered enabled. | ||
| func IsCGEnabled(ctx context.Context, apiReader client.Reader) bool { |
There was a problem hiding this comment.
Maybe now is the time to make this function specific to VGR and change the name to IsCGEnabledForVolRep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.