8000 Rasa cli by wochinge · Pull Request #1743 · RasaHQ/rasa_core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 22, 2019. It is now read-only.

Rasa cli #1743

Merged
merged 40 commits into from
Mar 6, 2019
Merged

Rasa cli #1743

merged 40 commits into from
Mar 6, 2019

Conversation

wochinge
Copy link
Contributor
@wochinge wochinge commented Feb 20, 2019 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • [ ] added some tests for the functionality
  • [ ] updated the documentation
  • updated the changelog

@wochinge wochinge marked this pull request as ready for review February 22, 2019 14:52
@wochinge wochinge requested a review from tmbo February 25, 2019 08:03
@wochinge
Copy link
Contributor Author

@tmbo Ready for review. I rely on the master version of NLU though, so the travis built won't pass.

@codeclimate
Copy link
codeclimate bot commented Feb 25, 2019 •
edited
Loading

Code Climate has analyzed commit 8fc8cfa and detected 15 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 13
Duplication 2

View more on Code Climate.

tmbo
tmbo approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member
@tmbo tmbo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions, all in all looks good

@tmbo tmbo mentioned this pull request Feb 27, 2019
Merged
4 tasks
wochinge and others added 16 commits February 28, 2019 11:16
@wochinge
remove wrong commited loggings
5bf9e6e
@wochinge
add function renamings to migration guide
682a85e
@wochinge
improve migration guide for renamings
b7860d3
@wochinge
narrow done type annotation for handle_text
8e5371a
@wochinge
Merge branch 'master' into rasa-cli
38359d0
@wochinge
remove encoding since it is not support for binary mode
4c0ba52
@wochinge
re-add quotes around types since it otherwise leads to error
48b1bdf
@wochinge
fix imports
3d28ab4
@wochinge
Merge branch 'master' into rasa-cli
7fa00bc
@wochinge
change data stuff to old directories since we are not using separate …
2953ff3 
…directories anymore
@wochinge
Merge branch 'rasa-cli' of github.com:RasaHQ/rasa_core into rasa-cli
7d3f716
@wochinge
remove interactive training directories from changelog
19a55a3
@wochinge
fix pycodestyle
be865b3
@wochinge
fix import of test module
c3daed6
@wochinge
change test discovery to test_ so that rasa_core.test() is not discov…
1fc2bdd 
…ered
@wochinge
Merge branch 'master' into rasa-cli
8fc8cfa
@wochinge
Copy link
Contributor Author
wochinge commented Mar 6, 2019 •
edited
Loading

@tmbo Quick note: I had to change the test discovery to test_ since pytest otherwise tried to execute the test method of rasa_core.test: 1fc2bdd

If this is okay, I'd merge.

@tmbo
Copy link
Member
tmbo commented Mar 6, 2019

Yes sounds good 👍

@wochinge wochinge merged commit d21373c into master Mar 6, 2019
@tmbo tmbo deleted the rasa-cli branch March 8, 2019 12:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tmbo tmbo tmbo approved these changes

@JustinaPetr JustinaPetr JustinaPetr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wochinge @tmbo @JustinaPetr
0