8000 Inclusion of rtweekend.h still unclear · Issue #1628 · RayTracing/raytracing.github.io · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Inclusion of rtweekend.h still unclear #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
whydoubt opened this issue Aug 29, 2024 · 0 comments
Closed

Inclusion of rtweekend.h still unclear #1628

whydoubt opened this issue Aug 29, 2024 · 0 comments
Assignees
@hollasch
Labels
area: book area: code level: patch
Milestone
v4.0.1

Comments

@whydoubt
Copy link
Contributor
whydoubt commented Aug 29, 2024 •
edited
Loading

1.6.7 states "All main program files will include rtweekend.h first, so most other header files (where the bulk of our code will reside) can assume these definitions are already available."

I read that as: main.cc includes it up top, so we don't have to include it elsewhere. However, the source code is inconsistent with that premise, but the source code is also inconsistent with itself. Just looking at the other files mentioned in section 1.6.7 as needing changes:

  • color.h, sphere.h, vec3.h in the src folder do NOT include rtweekend.h
  • hittable.h, hittable_list.h in the src folder DO include rtweekend.h

Additionally, camera.h and material.h, which are introduced later, both include rtweekend.h in both the book and the src folder.

This effects of this carry over to the other books.
@hollasch hollasch assigned hollasch and unassigned hollasch Aug 29, 2024
@hollasch hollasch added this to the v4.0.2 milestone Aug 29, 2024
hollasch added a commit that referenced this issue Aug 29, 2024
@hollasch
Headers assume implicit rtweekened.h include
8a3212f 
Resolves #1628
@hollasch hollasch modified the milestones: v4.0.2, v4.0.1 Aug 29, 2024
@hollasch hollasch self-assigned this Aug 29, 2024
@hollasch hollasch mentioned this issue Aug 29, 2024
Closed
hollasch added a commit that referenced this issue Aug 29, 2024
@hollasch
Headers assume implicit rtweekend.h include
2d3ad0f 
Resolves #1628
hollasch added a commit that referenced this issue Aug 29, 2024
@hollasch
Headers assume implicit rtweekend.h include
00c12a2 
Resolves #1628
@hollasch hollasch mentioned this issue Aug 29, 2024
Merged
hollasch added a commit that referenced this issue Aug 30, 2024
@hollasch
Headers assume implicit rtweekend.h include
f0ade8e 
Resolves #1628
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollasch hollasch

Labels
area: book area: code level: patch
Projects
None yet
Milestone
v4.0.1
Development

No branches or pull requests
2 participants
@hollasch @whydoubt
0