Render updates 2 #623
Closed
Render updates 2 #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add extra blank line before code listing highlighting changes - Add missing text change highlights - Add missing header includes - Organize main() chunks: image params, then world def, then camera def, then image render - Images parameters updated for new renders - Some code listings get more context - Fix trivial code format issues - Add missing code listings - Side-by-side antialising illustration - Fix source file name error for fig-1.09 - Change render image includes to use new names (coming in next commit) - Improve code for distinct world material + geometry definitions - Include render parameters for final scene
- Add more double-line spacers - Organize main() chunks: image params, then world definitions, then camera defs, then render - Change class order in material.h to match book definition order - Eliminate duplicated code in dielectric::scatter() - Delete vestigal vec3::write_color() method (now in color.h)
|
Uuuh. I'm not seeing better images. These still have the epsilon artifacting. |
|
Grrrrr.... Not sure how I fumbled this. Sigh. |
|
0b11 time's the charm, I hope. See #625 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #179
Resolves #547
Resolves #548
Resolves #549
Resolves #550
Resolves #551
Resolves #552
Resolves #553
Resolves #554
Resolves #555
Resolves #556
Resolves #557
Resolves #560
Resolves #561
Resolves #562
Resolves #563
Resolves #564
Resolves #565
Resolves #566
Book 1 render updates: text changes
then image render
Book 1 render updates: code changes
camera defs, then render