Load images in linear gamma #1450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using the STBI `stbi_load()` function, which loads gamma-corrected byte data from the given image. Instead, we want our image data to be in linear space for internal computation, with a final gamma=2 correction applied when we write the rendered result. Happily, there's an `stbi_loadf()` function that loads linearly-encoded image data as triples of 32-bit floating-point values. We don't really need to explain all the machinery, as we kind of just plop `rtw_stb_image.h` down for the readers to use. I do add some explanation though that we want loaded images to be in linear color space. Resolves #842
armansito
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the STBI
stbi_load()function, which loads gamma-corrected byte data from the given image.Instead, we want our image data to be in linear space for internal computation, with a final gamma=2 correction applied when we write the rendered result.
Happily, there's an
stbi_loadf()function that loads linearly-encoded image data as triples of 32-bit floating-point values.We don't really need to explain all the machinery, as we kind of just plop
rtw_stb_image.hdown for the readers to use. I do add some explanation though that we want loaded images to be in linear color space.Resolves #842