Monsters #170
Monsters #170
Conversation
* finish Spider and add to EntityRenderDispatcher * finish Skeleton, Arrow, ArrowRenderer class and add to EntityRenderDispatcher * instantiate Bow in item init fn * adjusted HumanoidMobRenderer to support carried items
* Added platform-agnostic AppPlatform::readAssetFile()
| @@ -192,6 +192,15 @@ void Player::aiStep() | |||
| } | |||
| } | |||
|
|
|||
| ItemInstance* Player::getCarriedItem() | |||
| { | |||
| auto inst = m_pInventory->getItem(m_pInventory->m_selectedHotbarSlot); | |||
There was a problem hiding this comment.
Can't use auto here, need to maintain C++03 support.
|
|
||
| void Skeleton::checkHurtTarget(Entity* ent, float f) | ||
| { | ||
| if (f < 10.0f) { |
There was a problem hiding this comment.
Indentation doesn't match everything else.
| public: | ||
| Skeleton(Level* pLevel); | ||
|
|
||
| std::string getAmbientSound() const override { return "mob.skeleton"; }; |
There was a problem hiding this comment.
Random trailing semi-colon.
| public: | ||
| Spider(Level* pLevel); | ||
|
|
||
| std::string getAmbientSound() const override { return "mob.spider"; }; |
There was a problem hiding this comment.
Random trailing semi-colon.
| m_attackDamage = 5; | ||
| } | ||
|
|
||
| void Zombie::aiStep() { |
There was a problem hiding this comment.
Indentation doesn't match everything else.
| { | ||
| min -= Vec3(x, x, x); | ||
| max += Vec3(x, x, x); | ||
| return *this; |
There was a problem hiding this comment.
Why is this being cloned?
| TileID m_lastTile; | ||
| bool m_inGround = false; | ||
| int m_life; | ||
| int m_flightTime = 0; |
There was a problem hiding this comment.
Member variables must be initialized in the constructor in C++03.
| } | ||
| } | ||
|
|
||
| if (hit_ent != nullptr) { |
There was a problem hiding this comment.
Indentation doesn't match everywhere else.
|
|
||
| float max_dist = 0.0f; | ||
| float var10 = 0.3f; | ||
| for (Entity* ent : entities) |
There was a problem hiding this comment.
Cannot use foreach syntax on C++03. Please use ::iterator instead. There are examples of this in the codebase.
| return 0; | ||
|
|
||
| float br = (1.0f - reinterpret_cast<Spider*>(spider)->getBrightness(1.0f)) * 0.5f; | ||
| glEnable(3042); |
There was a problem hiding this comment.
The numbers here should be GL_ enums.
How should I feel?
Creatures lie here
Looking through the window
Monster