8000 feat: Update to patcher v22 by LisoUseInAIKyrios · Pull Request #4409 · ReVanced/revanced-patches · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Update to patcher v22 #4409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 238 commits into
base: dev
Choose a base branch
from

Conversation

LisoUseInAIKyrios
Copy link
8000
Contributor
@LisoUseInAIKyrios LisoUseInAIKyrios commented Feb 3, 2025

Initial usage of Patcher v22 method instruction filters.

ReVanced/revanced-patcher#329

…tion_filters

# Conflicts:
#	patches/src/main/kotlin/app/revanced/patches/youtube/video/speed/custom/CustomPlaybackSpeedPatch.kt
…tion_filters

# Conflicts:
#	patches/src/main/kotlin/app/revanced/patches/youtube/misc/fix/cairo/DisableCairoSettingsPatch.kt
#	patches/src/main/kotlin/app/revanced/patches/youtube/misc/fix/cairo/Fingerprints.kt
@LisoUseInAIKyrios
Copy link
Contributor Author

Ok I found the other flag (45680008L). Not sure why it didn't show when I first searched.

The animations seem like a work in progress, or maybe something is half broken due to some other patch. The first time clicking a tab the animations are a left/right slide with a broken appearance. Then after it opens once it uses the horizontal slide up/down animation.

@0xrxL
Copy link
0xrxL commented Jun 5, 2025

Ok I found the other flag (45680008L). Not sure why it didn't show when I first searched.

The animations seem like a work in progress, or maybe something is half broken due to some other patch. The first time clicking a tab the animations are a left/right slide with a broken appearance. Then after it opens once it uses the horizontal slide up/down animation.

Probably you added a one more zero 😂

P.S: Yeah, the direction change if you already opened the tab.

@LisoUseInAIKyrios
Copy link
Contributor Author

If flag 45680008L is enabled then the navigation tab animation works correctly on the first tap. The other two flags don't appear to be needed.

@0xrxL
Copy link
0xrxL commented Jun 5, 2025

If flag 45680008L is enabled then the navigation tab animation works correctly on the first tap. The other two flags don't appear to be needed.

...009 enable the animation after search button tap.

@LisoUseInAIKyrios
Copy link
Contributor Author

If 45680009L is enabled at the same time as 45680008L then the tab animations are wrong for the first tap (described above).

@0xrxL
Copy link
0xrxL commented Jun 5, 2025

Other useful flags:

New UI style cast button (it's practically same as the current button, but it's managed by another class, because can't be hidden with the already implemented patch) --->

45690090L
45690091L

Ui Animation fade after opening a video --->

45387489L

Litho empty elements (during loading) colored --->

45412406L

Picture-in-Picture shortcut inside video player other settings (where options like video loop are placed, to be clearer) --->

45427407L

@0xrxL
Copy link
0xrxL commented Jun 5, 2025

If 45680009L is enabled at the same time as 45680008L then the tab animations are wrong for the first tap (described above).

Really? And search button animation is still present with only ...008?

@LisoUseInAIKyrios
Copy link
Contributor Author

Search animation is not on unless 45680009L is enabled, but the nav animations are half broken if it's also enabled at the same time as 45680008L

@0xrxL
Copy link
0xrxL commented Jun 5, 2025

Ok...so I must chase between search animation or partially broken navigation bar animations. Maybe I can keep both enabled and find the broken animation method. 🤔

…tion_filters

# Conflicts:
#	extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/theme/SeekbarColorPatch.java
#	patches/src/main/kotlin/app/revanced/patches/youtube/layout/theme/Fingerprints.kt
#	patches/src/main/kotlin/app/revanced/patches/youtube/layout/theme/ThemePatch.kt
…read local (20.22 buffer issue still not fixed)
…tion_filters

# Conflicts:
#	patches/src/main/kotlin/app/revanced/patches/bandcamp/limitations/Fingerprints.kt
… as first thought, and complicates custom filter"

This reverts commit b6eb1ce.
@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the feat/patcher_instruction_filters branch from 9c1b33d to f445a44 Compare June 8, 2025 12:05
@Nuckyz
Copy link
Member
Nuckyz commented Jun 8, 2025

@LisoUseInAIKyrios Is there a reason Remove player controls background does not add an option to toggle the functionality and thus is the only patch to hide something which is use = false?

@LisoUseInAIKyrios
Copy link
Contributor Author

The patch modifies a layout file, so it can't use a runtime setting.

But I'm pretty sure a bytecode patch could be made to apply the same change after the layout is loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
0