feat(Cricbuzz): Add Hide ads patch
#4998
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oSumAtrIX
reviewed
May 19, 2025
patches/src/main/kotlin/app/revanced/patches/cricbuzz/Fingerprints.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
May 19, 2025
patches/src/main/kotlin/app/revanced/patches/cricbuzz/DisableAdsPatch.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
May 19, 2025
patches/src/main/kotlin/app/revanced/patches/cricbuzz/DisableAdsPatch.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
May 19, 2025
patches/src/main/kotlin/app/revanced/patches/cricbuzz/DisableAdsPatch.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
May 19, 2025
Disable ads patch
oSumAtrIX
reviewed
May 19, 2025
patches/src/main/kotlin/app/revanced/patches/cricbuzz/Fingerprints.kt
Outdated
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/cricbuzz/DisableAdsPatch.kt
Outdated
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/cricbuzz/DisableAdsPatch.kt
Outdated
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/cricbuzz/ads/DisableAdsPatch.kt
Outdated
Show resolved
Hide resolved
Disable ads patchHide ads patch
patches/src/main/kotlin/app/revanced/patches/cricbuzz/ads/DisableAdsPatch.kt
Outdated
Show resolved
Hide resolved
Nuckyz
reviewed
Jun 5, 2025
|
|
||
| @Suppress("unused") | ||
| val disableAdsPatch = bytecodePatch ( | ||
| "Hide ads", |
There was a problem hiding this comment.
Suggested change
| "Hide ads", | |
| name = "Hide ads", |
| val disableAdsPatch = bytecodePatch ( | ||
| "Hide ads", | ||
| ) { | ||
| compatibleWith("com.cricbuzz.android" ("6.23.02")) |
There was a problem hiding this comment.
Suggested change
| compatibleWith("com.cricbuzz.android" ("6.23.02")) | |
| compatibleWith("com.cricbuzz.android"("6.23.02")) |
There was a problem hiding this comment.
Everywhere else in the patches repo uses no space. If this is changed it should be changed everywhere.
There was a problem hiding this comment.
But the suggestion is to remove the space, not add it
|
|
||
| internal val userStateSwitchFingerprint = fingerprint { | ||
| strings("key.user.state", "NA") | ||
| opcodes(Opcode.SPARSE_SWITCH) |
There was a problem hiding this comment.
Are the strings enough or is this Opcode needed?
|
|
||
| execute { | ||
| userStateSwitchFingerprint.method.apply { | ||
| val opcodeIndex = indexOfFirstInstructionOrThrow(Opcode.MOVE_RESULT_OBJECT) |
There was a problem hiding this comment.
Name these variables in a way that we know what these instructions do. For example:
- What is this return we are moving-result-object to?
- What is stored in the register we are getting?
Comment on lines
+20
to
+23
| val insertIndex = opcodeIndex + 1 | ||
|
|
||
| addInstructions( | ||
| insertIndex, |
There was a problem hiding this comment.
Suggested change
| val insertIndex = opcodeIndex + 1 | |
| addInstructions( | |
| insertIndex, | |
| addInstruction( | |
| opcodeIndex + 1, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add patch to disable ads on cricbuzz app