feat(YouTube): Use modern style settings dialogs #5109
Conversation
|
I think there could be more padding between the dialog text and the title and buttons. The "Do you wish to proceed" disclaimer text looks a little cramp. |
|
I tried to use the same padding as in the original dialogs, but nothing is stopping us from setting our own. |
|
I think the small padding works ok for the stock YT dialogs, since the dialog message is just one line. I think the title might look better if the text is centered. |
|
Import export dialog |
Look at this |
Not sure if the localized text will fit in the buttons, or if it's possible to show Cancel in the second row. |
I think the dialog message text might be a little larger font. And maybe the title a little smaller font. Maybe there's a simple way to automatically reduce the title font if needed so it always fits on one line? Otherwise looks good. |
|
Now. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Is two rows needed for localized languages that have long translations? I think the one row looks a little better, but I know multiple rows may be needed since the stock dialog shows multiple rows if needed. https://i.sstatic.net/qZchE.png Could this behave the same as the stock dialog screenshot above, and show vertical buttons if the button text is too large otherwise always show horizontal (single row) buttons? |
|
When the buttons are in 1 row, it seems to fit, because the font is smaller and has no caps. In the standard Alertdialog, I always had problems with moving the buttons to a new row. So I decided to play it safe. Maybe it makes sense to return 1 row, since the screenshots above show that there were no problems at the moment. Or do "show vertical buttons if the button text is too large otherwise always show horizontal (single row) buttons" |
|
If it fits on one line then always using one line is better. But some translations may have really long text so maybe the button text needs to automatically shrink if needed. |
|
What about other dialogs (language, quality, speed)? It is also possible to change the style. |
|
I think quality is the only one left? Speed is already the new dialog. Language is a YT built in dialog, right? |
|
I mean this (in settings). |
|
Oh, there. Yeah can make a custom list preference if you want. |
|
I can't find where the dialogs for quality, speed, language are created, it's definitely not |
|
The dialog is created in the Android stock |
|
Maybe instead of official website, you can write revanced.app And maybe use title case for the dialog? Checks Failed instead of Checks failed |
Since I don't know much English, I'll leave it to the devs to decide. |
|
Last changes. |
|
Also how to check |
|
For the color picker I think the buttons at the bottom (reset, cancel, ok) need more vertical padding between the manual color string edit text (#FF0033). Not sure how or if the announcements can be force but maybe @oSumAtrIX has a suggestion. |
|
|
|
I think I replaced almost all the dialogues, only the dialogues left when creating the SB segments, which I'm not very interested in. |
|
Is this entirely focused on YouTube or does it change any other apps too? |
|
There are only 2 AlertDialog (excluding ListPreference) in TikTok, which I don't use on principle. Anyone interested can integrate this. |
Just asking to update the PR title haha |
|
I think it's ready to review. |
Use modern style settings dialogs in accordance with YouTube's updated dialog design (#4409 (comment)).
TODO: