8000 Make `_T` in `Observable[_T]` covariant by Azureblade3808 · Pull Request #654 · ReactiveX/RxPY · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make _T in Observable[_T] covariant #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2022
Merged

Make _T in Observable[_T] covariant #654

merged 2 commits into from
Jul 2, 2022

Conversation

Azureblade3808
Copy link
Contributor

Fixes #653

@coveralls
Copy link
coveralls commented Jun 29, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 93.375% when pulling c8c0109 on Azureblade3808:patch-1 into 5d8b06c on ReactiveX:master.

@dbrattli dbrattli self-requested a review July 2, 2022 09:39
dbrattli
dbrattli approved these changes Jul 2, 2022
View reviewed changes
Copy link
Collaborator
@dbrattli dbrattli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look great! Thanks for fixing!

@dbrattli dbrattli merged commit 4d351c9 into ReactiveX:master Jul 2, 2022
@Azureblade3808 Azureblade3808 deleted the patch-1 branch July 3, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrattli dbrattli dbrattli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type-var _T in Observable[_T] should be covariant
3 participants
@Azureblade3808 @coveralls @dbrattli
0