choose appropriate legend mark for when visualizing text #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pburnsdata
reviewed
Feb 6, 2020
| @@ -86,7 +88,7 @@ export default function drawText(marks) { | |||
| return config.y.type === 'ordinal' ? yPos + this.y.rangeBand() / 2 : yPos; | |||
| }); | |||
|
|
|||
| // add a reference to the selection from it's data | |||
| // add a reference to the selection from its data | |||
pburnsdata
reviewed
Feb 6, 2020
| order = item.direction === 'ascending' ? +aCell - +bCell : +bCell - +aCell; | ||
| } else { | ||
| if (order === 0) { | ||
| if (order === 0) { |
There was a problem hiding this comment.
this makes more sense to me now
pburnsdata
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Closes #42