Thor: Add central package management & lock with Github Action cache #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* **Directory.Packages.p 8000 rops**: Add file to manage package versions centrally. * **Netatmo.csproj**: Remove version numbers from package references. * **Netatmo.Tests.csproj**: Remove version numbers from package references. * **README.md**: Add section about central package management.
Add build and test tasks to `.devcontainer/devcontainer.json` * Add "tasks" section with "build" and "test" commands * Use `dotnet restore` and `dotnet build` for the build task * Use `dotnet restore` and `dotnet test` for the test task
* **Directory.Packages.props** - Add `<RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>` property * **.devcontainer/devcontainer.json** - Update build and test tasks to use `--locked-mode` for `dotnet restore` * **tests/TestApp/packages.lock.json** - Add new package lock file * **src/Netatmo/packages.lock.json** - Add new package lock file * **tests/Netatmo.Tests/packages.lock.json** - Add new package lock file
There was a problem hiding this comment.
Copilot reviewed 4 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (7)
- .devcontainer/devcontainer.json: Language not supported
- Directory.Packages.props: Language not supported
- azure-pipelines.yml: Language not supported
- src/Netatmo/Netatmo.csproj: Language not supported
- src/Netatmo/packages.lock.json: Language not supported
- tests/Netatmo.Tests/Netatmo.Tests.csproj: Language not supported
- tests/TestApp/packages.lock.json: Language not supported
There was a problem hiding this comment.
Copilot reviewed 4 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (7)
- .devcontainer/devcontainer.json: Language not supported
- Directory.Packages.props: Language not supported
- azure-pipelines.yml: Language not supported
- src/Netatmo/Netatmo.csproj: Language not supported
- src/Netatmo/packages.lock.json: Language not supported
- tests/Netatmo.Tests/Netatmo.Tests.csproj: Language not supported
- tests/TestApp/packages.lock.json: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to implement central package management, improve CI workflows, and update package references. The most important changes include adding central package management to the repository, updating CI workflows to use locked package modes, and removing the Azure Pipelines configuration.
Central Package Management:
Directory.Packages.props: Added central package management for NuGet packages, including specifying package versions for multiple dependencies.src/Netatmo/Netatmo.csprojandtests/Netatmo.Tests/Netatmo.Tests.csproj: Updated package references to use central package management. [1] [2]CI Workflow Improvements:
.github/workflows/ci.ymland.github/workflows/tests.yml: Updated workflows to usedotnet restore --locked-modeand enabled caching forsetup-dotnetaction. [1] [2] [3]Removal of Azure Pipelines Configuration:
azure-pipelines.yml: Removed the Azure Pipelines configuration file as part of the transition to GitHub Actions for CI/CD.Documentation Update:
README.md: Added a section about central package management to inform developers about the new package management approach.Dev Container Update:
.devcontainer/devcontainer.json: Added build and test tasks to the dev container configuration to streamline development workflows.