8000 fix: Missing margin in E2EE room header toolbox items by dougfabris · Pull Request #35614 · RocketChat/Rocket.Chat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Missing margin in E2EE room header toolbox items #35614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 27, 2025
Merged

fix: Missing margin in E2EE room header toolbox items #35614

merged 4 commits into from
Mar 27, 2025

Conversation

dougfabris
Copy link
Member
@dougfabris dougfabris commented Mar 25, 2025 •
edited
Loading

Proposed changes (including videos or screenshots)

before

image

after

image

Issue(s)

Steps to test or reproduce

  • Enable E2EE feature
  • Create an encrypted room
  • Reset your E2EE key
  • Do not save or enter your E2EE key
  • Enter the encrypted room you created
  • Should display the toolbox items margin as the screenshots above

Further comments

CORE-1048

@dionisio-bot dionisio-bot
Copy link
Contributor
dionisio-bot bot commented Mar 25, 2025 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.6.0, but it targets 7.5.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Mar 25, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: a697cbc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris added this to the 7.6.0 milestone Mar 25, 2025
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Mar 25, 2025 •
edited
Loading
PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35614/

Built to branch gh-pages at 2025-03-26 20:22 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov Codecov
Copy link
codecov bot commented Mar 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.72%. Comparing base (a4f2ecb) to head (a697cbc).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35614   +/-   ##
========================================
  Coverage    59.72%   59.72%           
========================================
  Files         2829     2829           
  Lines        68243    68243           
  Branches     15126    15126           
========================================
  Hits         40759    40759           
  Misses       24876    24876           
  Partials      2608     2608
Flag Coverage Δ
unit 75.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris changed the title fix: Missing margin in E2EE room header toolbox fix: Missing margin in E2EE room header toolbox items Mar 25, 2025
@dougfabris dougfabris force-pushed the fix/room-toolbox-e2eSetup branch from 1df187b to 7906efe Compare March 25, 2025 19:25
@dougfabris dougfabris marked this pull request as ready for review March 25, 2025 21:07
@dougfabris dougfabris requested a review from a team as a code owner March 25, 2025 21:07
juliajforesti
juliajforesti requested changes Mar 25, 2025
View reviewed changes
juliajforesti
juliajforesti requested changes Mar 25, 2025
View reviewed changes
Copy link
Contributor
@juliajforesti juliajforesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝🏽

@juliajforesti juliajforesti added the stat: QA assured Means it has been tested and approved by a company insider label Mar 27, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 27, 2025
@kodiakhq kodiakhq bot merged commit 6e2b583 into develop Mar 27, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the fix/room-toolbox-e2eSetup branch March 27, 2025 13:33
@rocketchat-github-ci rocketchat-github-ci mentioned this pull request Apr 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliajforesti juliajforesti juliajforesti approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
7.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dougfabris @juliajforesti
0