feat: Add Pagination to App logs page #36067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: a8c09ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #36067 +/- ##
===========================================
- Coverage 64.96% 64.95% -0.02%
===========================================
Files 3113 3113
Lines 93725 93755 +30
Branches 17804 17804
===========================================
+ Hits 60889 60899 +10
- Misses 30052 30075 +23
+ Partials 2784 2781 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
8000
aleksandernsilva
requested changes
May 23, 2025
apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppLogs/AppLogs.tsx
Outdated
Show resolved
Hide resolved
aleksandernsilva
requested changes
May 26, 2025
Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
aleksandernsilva
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only on
2E47
e suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Adds a pagination component to the App Logs list. Allowing the user to see all the logs, instead of only the latest ones
Issue(s)
ALT-4
Further comments
I have not added tests in this PR for 2 reasons: