fix: AgentEdit departments field not being paginated #36038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 310c46f The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
31ad325 to
83bc525
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #36038 +/- ##
===========================================
+ Coverage 64.94% 64.96% +0.02%
===========================================
Files 3112 3111 -1
Lines 93729 93712 -17
Branches 17806 17806
===========================================
+ Hits 60870 60880 +10
+ Misses 30071 30050 -21
+ Partials 2788 2782 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
65922e9 to
8015fb0
Compare
0d666c9 to
fe56d6a
Compare
8015fb0 to
a60191b
Compare
5a588ce to
c982530
Compare
c982530 to
7682a8f
Compare
7682a8f to
a573ab8
Compare
MartinSchoeler
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR updates the department field in the AgentEdit page to use the AutoCompleteDepartmentsMultiple component, replacing the custom logic we had before. The new component already supports lazy loading and pagination.
Issue(s)
CTZ-157
Steps to test or reproduce
Further comments