8000 feat: Improve form responsiveness in profile page by juliajforesti · Pull Request #36114 · RocketChat/Rocket.Chat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Improve form responsiveness in profile page #36114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 3, 2025
Merged

feat: Improve form responsiveness in profile page #36114

merged 6 commits into from
Jun 3, 2025

Conversation

juliajforesti
Copy link
Contributor
@juliajforesti juliajforesti commented May 29, 2025 •
edited by dougfabris
Loading

Proposed changes (including videos or screenshots)

before

image

after

image

Issue(s)

closes #36041

Steps to test or reproduce

Further comments

CORE-1182

@dionisio-bot dionisio-bot
Copy link
Contributor
dionisio-bot bot commented May 29, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented 8000 May 29, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 93eb193

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 29, 2025 •
edited
Loading
PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36114/

Built to branch gh-pages at 2025-06-03 01:50 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov Codecov
Copy link
codecov bot commented May 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.94%. Comparing base (d47478a) to head (93eb193).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36114      +/-   ##
===========================================
- Coverage    64.98%   64.94%   -0.05%     
===========================================
  Files         3112     3112              
  Lines        93749    93753       +4     
  Branches     17811    17810       -1     
===========================================
- Hits         60926    60889      -37     
- Misses       30039    30075      +36     
- Partials      2784     2789       +5
Flag Coverage Δ
e2e 58.42% <50.00%> (-0.07%) ⬇️
unit 71.62% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliajforesti juliajforesti marked this pull request as ready for review May 30, 2025 17:33
@juliajforesti juliajforesti requested a review from a team as a code owner May 30, 2025 17:33
@juliajforesti juliajforesti added this to the 7.8.0 milestone May 30, 2025
@dougfabris dougfabris changed the title feat: improve Profile page responsiveness feat: Improve form responsiveness in profile page Jun 2, 2025
dougfabris
dougfabris requested changes Jun 2, 2025
View reviewed changes
@juliajforesti juliajforesti requested a review from dougfabris June 2, 2025 20:08
dougfabris
dougfabris approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member
@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Jun 2, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 2, 2025
@kodiakhq kodiakhq bot merged commit 38c5dbd into develop Jun 3, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the feat/profile-form-responsive branch June 3, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougfabris dougfabris dougfabris approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
7.8.0
Development

Successfully merging this pull request may close these issues.

Delete My Account and Resend Verification Email Buttons Not Responsive in Mobile View
2 participants
@juliajforesti @dougfabris
0