8000 test: add end-to-end tests for delete own account functionality by jessicaschelly · Pull Request #36129 · RocketChat/Rocket.Chat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test: add end-to-end tests for delete own account functionality #36129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

test: add end-to-end tests for delete own account functionality #36129

wants to merge 9 commits into from
+243 −4

Conversation

jessicaschelly
Copy link
Member
@jessicaschelly jessicaschelly commented Jun 3, 2025 •
edited
Loading

Test Coverage:

User deletes own account functionality

  • Invalid password rejection (permission enabled)
  • Valid password deletion (permission enabled)
  • Button visibility when permission is disabled

🔗 Related Issues

Bug reported on:
https://rocketchat.atlassian.net/browse/CORE-1175
Fixed by: #35470

@dionisio-bot dionisio-bot
Copy link
Contributor
dionisio-bot bot commented Jun 3, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Jun 3, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: ec449e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets 8000

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 3, 2025 •
edited
Loading
PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36129/

Built to branch gh-pages at 2025-06-05 19:52 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov Codecov
Copy link
codecov bot commented Jun 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.57%. Comparing base (e9904fe) to head (ec449e8).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #36129   +/-   ##
========================================
  Coverage    64.56%   64.57%           
========================================
  Files         3123     3123           
  Lines        97850    97851    +1     
  Branches     18528    18593   +65     
========================================
+ Hits         63178    63186    +8     
+ Misses       31851    31840   -11     
- Partials      2821     2825    +4
Flag Coverage Δ
e2e 57.62% <50.00%> (+0.05%) ⬆️
unit 69.86% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jessicaschelly jessicaschelly changed the title test: add end-to-end tests for account deletion functionality test: add end-to-end tests for delete own account functionality Jun 4, 2025
@jessicaschelly jessicaschelly marked this pull request as ready for review June 4, 2025 18:37
@jessicaschelly jessicaschelly requested a review from a team as a code owner June 4, 2025 18:37
aleksandernsilva
aleksandernsilva requested changes Jun 4, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandernsilva aleksandernsilva Awaiting requested review from aleksandernsilva

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessicaschelly @aleksandernsilva
0