This repository was archived by the owner on Jun 6, 2023. It is now read-only.
parse GOAWAY error responses from Apple #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with latest x/net/http2.
|
Nice looks good, Could you add a test for the |
|
This is the GoAwayError from actually hitting Apple: I'm not sure how to get that to return from an http handler though. Any ideas? |
|
I'm looking at https://github.com/golang/net/blob/master/http2/transport_test.go#L2028 to see if I can write a test for this. |
|
Right now |
|
my comment on the PR assumed you could use |
catatsuy
added a commit
to mercari/gaurun
that referenced
this pull request
Oct 10, 2019
HTTP/2 was not available when overwriting TLSClientConfig. But Go 1.13 can be used with ForceAttemptHTTP2. If Apple returns an error for `http2/GoAwayError`, I change the wording of the error. But all we can do is retry. cf: * RobotsAndPencils/buford#71 * golang/go#14627
catatsuy
added a commit
to mercari/gaurun
that referenced
this pull request
Oct 10, 2019
HTTP/2 was not available when overwriting TLSClientConfig. But Go 1.13 can be used with ForceAttemptHTTP2. If Apple returns an error for `http2/GoAwayError`, I change the wording of the error. But all we can do is retry. cf: * RobotsAndPencils/buford#71 * golang/go#14627
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @bradfitz for his work on x/net/http2.
golang/go#14627
fixes #33.
(though it seems to be only getting one GOAWAY with these changes)
need latest http2: go get -u golang.org/x/net/http2