-
Notifications
You must be signed in to change notification settings - Fork 28
Release 1.0.3 #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.0.3 #44
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've done a lot to close testing gaps, so this looks good. I'd just like to see install/upgrade steps fleshed out in the README, but that can happen post-publish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thing, otherwise looks great
### Upgrading | ||
First, replace your current version of Foreman with the newest one from the [GitHub releases](https://github.com/Roblox/foreman/releases). If you don't remember where you have put the executable, running `where foreman` on Windows or `which foreman` on macOS and Linux should help you find it. | ||
|
||
The other step is to locate the `bin` directory created by foreman and delete the files there. It is as simple as opening `.foreman/bin`, which is located under the user directory (`%homepath%` on Windows or `$HOME` on macOS and Linux). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to add a similar (probably brief) section for the cargo
installation style, just to be thorough.
Sorry, something went wrong.
All reactions
-
👍 1 reaction
matthargett
ZoteTheMighty
CertifiedRice
Successfully merging this pull request may close these issues.
We've added a bunch of tests since the last time we tried this, it should be good to go now.