8000 Release 1.0.3 by oltrep · Pull Request #44 · Roblox/foreman · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Release 1.0.3 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Release 1.0.3 #44

merged 3 commits into from
Feb 7, 2022

Conversation

oltrep
Copy link
Contributor
@oltrep oltrep commented Feb 4, 2022

We've added a bunch of tests since the last time we tried this, it should be good to go now.

@github-actions
Copy link
github-actions bot commented Feb 4, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor
@matthargett matthargett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've done a lot to close testing gaps, so this looks good. I'd just like to see install/upgrade steps fleshed out in the README, but that can happen post-publish.

Copy link
Contributor
@ZoteTheMighty ZoteTheMighty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, otherwise looks great

### Upgrading
First, replace your current version of Foreman with the newest one from the [GitHub releases](https://github.com/Roblox/foreman/releases). If you don't remember where you have put the executable, running `where foreman` on Windows or `which foreman` on macOS and Linux should help you find it.

The other step is to locate the `bin` directory created by foreman and delete the files there. It is as simple as opening `.foreman/bin`, which is located under the user directory (`%homepath%` on Windows or `$HOME` on macOS and Linux).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to add a similar (probably brief) section for the cargo installation style, just to be thorough.

@oltrep oltrep merged commit 0d6b21f into master Feb 7, 2022
@oltrep oltrep deleted the release-v1.0.3 branch February 7, 2022 21:27
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0