8000 For LovyanGFX by riraosan · Pull Request #30 · Roger-random/ESP_8_BIT_composite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

For LovyanGFX #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

For LovyanGFX #30

wants to merge 8 commits into from

Conversation

riraosan
Copy link

@Roger-random

Hi. Thank you for your Contributions.

I have merged LovyanGFX and ESP_8_BIT_composite in my project. In doing so, I wanted to output signals to GPIO26 (ATOM Lite), so I modified your source.
I decided to define the output port with #define as I don't change it often.
Please merge if you like. I'll commit it for now.

@riraosan
Copy link
Author

Could someone please check?

@riraosan riraosan marked this pull request as ready for review March 26, 2022 06:48
@Roger-random
Copy link
Owner

Please provide more information, I do not understand the issue this pull request intends to solve.

I was not aware of LovyanGFX. A search found https://github.com/lovyan03/LovyanGFX but I saw nothing about composite video. Am I looking at the right thing?

@riraosan
Copy link
Author
riraosan commented Mar 27, 2022 •
edited
Loading

Hi. @Roger-random

There was a lack of story about my project using your source. I am sorry.

My goal is to commit the Panel_CVBS class to LovyanGFX.
I was allowed to use your ESP_8_BIT_composite library in Panel_CVBS. Thank you very much.

Briefly, I have replaced the ESP_8_BIT_GFX class with LovyanGFX in my project. I have not committed to LovyanGFX yet. It is currently under testing.

Here is my inventory project.( using PlatformIO)
https://github.com/riraosan/ESP_8_BIT_composite_Sample.git
https://github.com/riraosan/LovyanGFX/tree/CVBS

The following video shows how it works.
https://twitter.com/i/status/1506231971504013316

The modifications are as follows

  • I modified the NTSC signal to switch the output to the PH2.0 port (GPIO26) of ATOM Lite instead of GPIO25. (ENABLE_GPIO26)
  • I added a method to enable/disable copyAfterSwap from Panel_CVBS class. (setCopyAfterSwap : I didn't want to access the property directly from outside the class.)
  • I wanted to write data from Panel_CVBS in LovyanGFX class to the double buffer, so I added a method. (getComposite)

Best regards.

@Roger-random
Copy link
Owner

Thank you for clarifying.

I spent some time on the README file at https://github.com/lovyan03/LovyanGFX and it appears to have a number of features not in Adafruit's GFX library. In order to fully support the entire LovyanGFX library, I believe it will be better to have a separate Arduino library so we don't incur overhead for people who are not using LovyanGFX.

Option 1:

  • Fork this project and remove all references to Adafruit_GFX. Switch to LovyanGFX, and add code to support all LovyanGFX requirements. Submit to Arduino as separate library. Advantage: standalone and optimized for LovyanGFX. Disadvantage: will not pick up future bug fixes of ESP_8_BIT_Composite.

Option 2:

  • Create a new project that depends on ESP_8_BIT_Composite project. Create new class that uses an internal instance of ESP_8_BIT_Composite class to draw. (Similar to how ESP_8_BIT_GFX class has a private _pVideo) This new class has code to support all LovyanGFX requirements. Advantage: will pick up future features and bug fixes of ESP_8_BIT_Composite library. Disadvantage: includes overhead of Adafruit_GFX.

Since you are still testing LovyanGFX and have not yet committed, I will not merge this pull request until your evaluation is complete. Please let me know what you find in your testing! It would be good to know the advantages/disadvantages of AdafruitGFX vs. LovyanGFX.

In the meantime, I will open a new discussion thread (#31) to see if others want LovyanGFX support.

@riraosan
Copy link
Author
riraosan commented Apr 1, 2022

Hi @Roger-random
Thanks for your consideration.

I appreciate your advice.
I discussed the pull request with the author of LovyanGFX.
He said that he did not want to add composite output until he had to rely on other libraries to do so.

In the meantime, I would like to contribute to the Arduino community by creating a library that depends on ESP_8_BIT_composite and LovyanGFX.
In other words, I would like to choose option 1, which you mentioned.
May I fork your library and commit it to the Arduno community as a new library?

Best regards.

@Roger-random
Copy link
Owner

Please feel free to fork this library. I've released it under the MIT license to encourage derived work. You don't even have to ask for permission! But thank you for asking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riraosan @Roger-random
0