8000 fix: Correct path resolution for .vite-port file in ClineProvider by KJ7LNW · Pull Request #4007 · RooCodeInc/Roo-Code · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Correct path resolution for .vite-port file in ClineProvider #4007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

KJ7LNW
Copy link
Collaborator
@KJ7LNW KJ7LNW commented May 26, 2025

Context

This PR fixes the issue where ClineProvider was looking for the .vite-port file in the wrong location, causing it to always fall back to the default port.

When multiple development servers are launched in different repositories, each Vite server uses a different port:

Without correctly reading the .vite-port file, the application cannot connect to the right Vite server instance.

Implementation

Updated the path resolution in ClineProvider.ts to correctly point to the project root where the Vite development server creates the .vite-port file.

How to Test

  1. Start multiple development servers in different repositories
  2. Verify that the console no longer shows the error message about the port file not being found
  3. Verify that the application connects to the correct Vite server using the port specified in the .vite-port file

Fixes #4006


Important

Fixes path resolution for .vite-port file in ClineProvider.ts to ensure correct Vite server connection.

  • Behavior:
    • Fixes path resolution for .vite-port file in ClineProvider.ts to correctly point to the project root.
    • Ensures the application connects to the correct Vite server using the port specified in the .vite-port file.
  • Testing:
    • Start multiple development servers and verify no error message about the port file not being found.
    • Confirm the application connects to the correct Vite server.

This description was created by Ellipsis for cb246ee. You can customize this summary. It will automatically update as commits are pushed.

The ClineProvider was looking for the .vite-port file in the wrong location.
Updated the path resolution to correctly point to the project root where
the Vite development server creates the file.

Fixes: #4006
Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>
@KJ7LNW
Copy link
Collaborator Author
KJ7LNW commented May 26, 2025

@cte

@KJ7LNW KJ7LNW marked this pull request as draft May 26, 2025 20:18
@KJ7LNW KJ7LNW marked this pull request as ready for review May 26, 2025 20:18
Copy link
Collaborator
@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@mrubens mrubens merged commit 1e5bf74 into RooCodeInc:main May 26, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap May 26, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 26, 2025
mr-ryan-james pushed a commit to mr-ryan-james/Roo-Code that referenced this pull request May 27, 2025
…oCodeInc#4007)

The ClineProvider was looking for the .vite-port file in the wrong location.
Updated the path resolution to correctly point to the project root where
the Vite development server creates the file.

Fixes: RooCodeInc#4006

Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>
Co-authored-by: Eric Wheeler <roo-code@z.ewheeler.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Incorrect path resolution for .vite-port file in ClineProvider
2 participants
0