feat: Add OpenAI Compatible embedder for codebase indexing #4066
+1,464
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement OpenAiCompatibleEmbedder with batching and retry logic - Add configuration support for base URL and API key - Update UI with provider selection and input fields - Add comprehensive test coverage - Support for all OpenAI-compatible endpoints (LiteLLM, LMStudio, Ollama, etc.) - Add internationalization for 17 languages
- Fix field count expectations (4 fields including Qdrant) - Use specific test IDs for button selection - Fix input handling with clear() before type() - Use toHaveBeenLastCalledWith for better assertions - Fix status text matching with regex pattern
- Remove unused waitFor import to fix ESLint error - Fix test expectations to match actual component behavior for input fields - Simplify provider selection test by removing complex mock interactions - All CodeIndexSettings tests now pass (20/20)
| @@ -40,6 +40,9 @@ | |||
| "selectProviderPlaceholder": "选择提供商", | |||
| "openaiProvider": "OpenAI", | |||
| "ollamaProvider": "Ollama", | |||
| "openaiCompatibleProvider": "OpenAI 兼容", | |||
| "openaiCompatibleBaseUrlLabel": "基础 URL:", | |||
There was a problem hiding this comment.
The label value for openaiCompatibleBaseUrlLabel uses a half-width colon (:) instead of the full-width colon (：) used in similar labels (e.g. openaiKeyLabel). Consider changing it for consistency.
Suggested change
| "openaiCompatibleBaseUrlLabel": "基础 URL:", | |
| "openaiCompatibleBaseUrlLabel": "基础 URL：", |
| @@ -40,6 +40,9 @@ | |||
| "selectProviderPlaceholder": "选择提供商", | |||
| "openaiProvider": "OpenAI", | |||
| "ollamaProvider": "Ollama", | |||
| "openaiCompatibleProvider": "OpenAI 兼容", | |||
| "openaiCompatibleBaseUrlLabel": "基础 URL:", | |||
| "openaiCompatibleApiKeyLabel": "API 密钥:", | |||
There was a problem hiding this comment.
The label value for openaiCompatibleApiKeyLabel uses a half-width colon (:) rather than the full-width colon (：) seen in other labels like openaiKeyLabel and ollamaUrlLabel. Please update for consistency.
Suggested change
| "openaiCompatibleApiKeyLabel": "API 密钥:", | |
| "openaiCompatibleApiKeyLabel": "API 密钥：", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #4065
Description
This PR implements OpenAI Compatible embedder support for codebase indexing, enabling users to connect to any OpenAI-compatible API endpoint (LiteLLM, LMStudio, Ollama, etc.) for generating embeddings.
Key implementation details:
OpenAiCompatibleEmbedderwith intelligent batching and retry logicDesign choices:
Test Procedure
Automated Testing:
pnpm test- All 20+ new unit tests passpnpm lint- No linting errorspnpm check-types- All TypeScript types validManual Testing:
Type of Change
Pre-Submission Checklist
npm run lint).console.log) has been removed.npm test).mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.Documentation Updates
Additional Notes
This implementation supports all major OpenAI-compatible providers including:
The feature is fully backward compatible and doesn't affect existing embedder configurations.
Important
Adds support for OpenAI-compatible embedders in codebase indexing with new embedder class, configuration, UI integration, and comprehensive testing.
OpenAiCompatibleEmbedderclass for OpenAI-compatible API endpoints with batching and retry logic.codebase-index.tsto includeopenai-compatibleas an embedder provider.CodeIndexSettings.tsxto support dynamic provider selection.config-manager.ts.provider-settings.tsandglobal-settings.tsfor new configuration keys.openai-compatible.test.tsandconfig-manager.test.ts.service-factory.test.ts.OpenAiCompatibleEmbeddertoservice-factory.tsfor embedder creation.embeddingModels.tsto includeopenai-compatiblemodels.This description was created by
for 9755fd7. You can customize this summary. It will automatically update as commits are pushed.