8000 @directory not respecting .rooIgnore Fix by xyOz-dev · Pull Request #4075 · RooCodeInc/Roo-Code · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

@directory not respecting .rooIgnore Fix #4075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 29, 2025
Merged

@directory not respecting .rooIgnore Fix #4075

merged 3 commits into from
May 29, 2025

Conversation

xyOz-dev
Copy link
@xyOz-dev xyOz-dev commented May 28, 2025 •
edited by ellipsis-dev bot
Loading

Related GitHub Issue

Closes: #3598

Description

Fixed @Directory attachments to respect .rooignore files by integrating RooIgnoreController into the mentions processing pipeline

Test Procedure

See linked issue.

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.

Additional Notes

Will be creating a pr to docs shortly

Important

Fixes @directory mentions to respect .rooignore files by integrating RooIgnoreController into the mentions processing pipeline.

  • Behavior:
    • @directory mentions now respect .rooignore files by integrating RooIgnoreController into the mentions processing pipeline in index.ts.
    • Adds rooIgnoreController and showRooIgnoredFiles parameters to parseMentions() and getFileOrFolderContent() in index.ts.
    • Updates processUserContentMentions() in processUserContentMentions.ts to handle rooIgnoreController and showRooIgnoredFiles.
  • Task Class:
    • Updates Task class in Task.ts to pass rooIgnoreController and showRooIgnoredFiles to processUserContentMentions().
  • Misc:
    • Adds handling for ignored files in directory listings, marking them with a lock symbol if showRooIgnoredFiles is true.

This description was created by Ellipsis for 4885782. You can customize this summary. It will automatically update as commits are pushed.

@xyOz-dev xyOz-dev requested review from mrubens and cte as code owners May 28, 2025 13:02
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels May 28, 2025
ellipsis-dev[bot]
ellipsis-dev bot reviewed May 28, 2025
View reviewed changes
xyOz-dev and others added 2 commits May 28, 2025 14:07
@xyOz-dev @ellipsis-dev
Update src/core/mentions/index.ts
a9c2924 
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@xyOz-dev
Update index.ts
f7afeca
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label May 28, 2025
@daniel-lxs daniel-lxs added the documentation Improvements or additions to documentation label May 28, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap May 28, 2025
@daniel-lxs daniel-lxs added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels May 28, 2025
@daniel-lxs
Copy link
Collaborator

LGTM, solves the issue with mentions where ignored files are included regardless of the settings on .rooignore to be consistent with the list_files tool

@hannesrudolph hannesrudolph mentioned this pull request May 28, 2025
Open
@mrubens
Copy link
Collaborator
mrubens commented May 29, 2025

Does this still let you directly @-mention rooignored files if you want to manually add them to the context?

daniel-lxs
daniel-lxs reviewed May 29, 2025
View reviewed changes
Copy link
Collaborator
@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this hides the content of ignored files

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 29, 2025
@mrubens mrubens merged commit aa62654 into RooCodeInc:main May 29, 2025
18 checks passed
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap May 29, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 29, 2025
@xyOz-dev xyOz-dev mentioned this pull request May 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-lxs daniel-lxs daniel-lxs left review comments

@ellipsis-dev ellipsis-dev[bot] ellipsis-dev[bot] left review comments

@mrubens mrubens mrubens approved these changes

@cte cte Awaiting requested review from cte cte is a code owner

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer PR - Needs Review size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Roo Code Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The @directory attachment should respect .*ignore files
4 participants
@xyOz-dev @daniel-lxs @mrubens @hannesrudolph
0