8000 Turn Prompts tab into Modes tab and move support prompts to Settings by mrubens · Pull Request #4078 · RooCodeInc/Roo-Code · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Turn Prompts tab into Modes tab and move support prompts to Settings #4078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025

Conversation

mrubens
Copy link
Collaborator
@mrubens mrubens commented May 28, 2025

Description

The "Prompts" tab doesn't make much sense - it's really about "Modes". This PR changes the name and icon of the tab and moves the Support Prompts into a new tab in Settings.

Screenshots / Videos

Screenshot 2025-05-28 at 11 03 54 AM

Screenshot 2025-05-28 at 11 04 15 AM

Documentation Updates

Does this PR necessitate updates to user-facing documentation?

  • No documentation updates are required.
  • Yes, documentation updates are required.

Important

Renames 'Prompts' tab to 'Modes', moves support prompts to settings, and updates related UI components and translations.

  • UI Changes:
    • Rename 'Prompts' tab to 'Modes' in App.tsx and App.test.tsx.
    • Move support prompts to PromptsSettings.tsx in the settings section.
  • File Renames:
    • Rename PromptsView.tsx to ModesView.tsx.
    • Rename PromptsView.test.tsx to ModesView.test.tsx.
  • Translations:
    • Update translations in multiple language files to reflect 'Modes' instead of 'Prompts'.
  • Miscellaneous:
    • Change icon for 'promptsButtonClicked' command in package.json.

This description was created by Ellipsis for 5f1c76d. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested a review from cte as a code owner May 28, 2025 15:06
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. documentation Improvements or additions to documentation UI/UX UI/UX related or focused labels May 28, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label May 28, 2025
@hannesrudolph hannesrudolph moved this from Triage to PR [Needs Preliminary Review] in Roo Code Roadmap May 28, 2025
@hannesrudolph
Copy link
Collaborator

@mrubens what if we went a step further and moved the modes settings menu down below the chat box like cline does?
Pasted_Image_2025-05-28__3_14 PM

@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels May 28, 2025
Copy link
Collaborator
@canrobins13 canrobins13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; worth considering rather this page and MCP belong as settings tabs because it's not really clear to me why they're in the top bar now

@@ -83,7 +83,7 @@
{
"command": "roo-cline.promptsButtonClicked",
"title": "%command.prompts.title%",
"icon": "$(notebook)"
"icon": "$(organization)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this live in the top bar instead of a settings tab?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question... we didn't have settings tabs at the time, mainly 😄

@@ -0,0 +1,193 @@
import React, { useState, useEffect } from "react"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth having Roo write some unit tests

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 28, 2025
@mrubens
Copy link
Collaborator Author
mrubens commented May 28, 2025

Thanks for the feedback @canrobins13 and @hannesrudolph - let me merge this for now and we can follow up on the UI. Definitely think there's still room for improvement 🙏

@mrubens mrubens merged commit 12669e1 into main May 28, 2025
14 checks passed
@mrubens mrubens deleted the modes_tab branch May 28, 2025 21:47
@github-project-automation github-project-automation bot moved this from PR [Needs Prelim Review] to Done in Roo Code Roadmap May 28, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer PR - Needs Preliminary Review size:L This PR changes 100-499 lines, ignoring generated files. UI/UX UI/UX related or focused
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants
0