-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Turn Prompts tab into Modes tab and move support prompts to Settings #4078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mrubens what if we went a step further and moved the modes settings menu down below the chat box like cline does? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; worth considering rather this page and MCP belong as settings tabs because it's not really clear to me why they're in the top bar now
@@ -83,7 +83,7 @@ | |||
{ | |||
"command": "roo-cline.promptsButtonClicked", | |||
"title": "%command.prompts.title%", | |||
"icon": "$(notebook)" | |||
"icon": "$(organization)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this live in the top bar instead of a settings tab?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question... we didn't have settings tabs at the time, mainly 😄
@@ -0,0 +1,193 @@ | |||
import React, { useState, useEffect } from "react" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth having Roo write some unit tests
Thanks for the feedback @canrobins13 and @hannesrudolph - let me merge this for now and we can follow up on the UI. Definitely think there's still room for improvement 🙏 |
Description
The "Prompts" tab doesn't make much sense - it's really about "Modes". This PR changes the name and icon of the tab and moves the Support Prompts into a new tab in Settings.
Screenshots / Videos
Documentation Updates
Does this PR necessitate updates to user-facing documentation?
Important
Renames 'Prompts' tab to 'Modes', moves support prompts to settings, and updates related UI components and translations.
App.tsx
andApp.test.tsx
.PromptsSettings.tsx
in the settings section.PromptsView.tsx
toModesView.tsx
.PromptsView.test.tsx
toModesView.test.tsx
.package.json
.This description was created by
for 5f1c76d. You can customize this summary. It will automatically update as commits are pushed.