-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Move task to end of initial message to prevent it from being drowned out by environment details. #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…out by environment details.
|
All reactions
Sorry, something went wrong.
// prepend environment details as its own text block, separate from tool results | ||
userContent.unshift({ type: "text", text: environmentDetails }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nissa-seru should we do this for every message like this or just the original task? Hope I'm not stepping on toes with this commit.
Sorry, something went wrong.
All reactions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix - sorry about that. I believe it's correct as you currently have it, in that the environment details are sent along with each API request payload but not on each message in the chat history - I believe that's the purpose of that line. The abstraction is messy enough that a quick run in debug mode (exporting the task to check that the order is correct and that it's not being replicated for each message) may be best.
Sorry, something went wrong.
All reactions
I think this makes sense and seems like an improvement? Would be really nice to have some evals to run it through with different providers and models though. @cte do you think we could do something rough here? |
All reactions
Sorry, something went wrong.
Yeah, I think I can set something quick up based on a WIP I have that uses Aider's benchmarks. |
All reactions
Sorry, something went wrong.
I think this is still worth eval'ing, but it also seems related to #3101. |
All reactions
Sorry, something went wrong.
mrubens
stea9499
ColemanRoo
cte
Successfully merging this pull request may close these issues.
Important
In
Cline.ts
,startTask()
now appends environment details before the task message to improve task visibility.Cline.ts
,startTask()
now appends environment details before the task message ininitiateTaskLoop()
to ensure task visibility.startTask()
for consistency.This description was created by
for 0b38426. It will automatically update as commits are pushed.