8000 Move task to end of initial message to prevent it from being drowned out by environment details. by nissa-seru · Pull Request #894 · RooCodeInc/Roo-Code · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move task to end of initial message to prevent it from being drowned out by environment details. #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

nissa-seru
Copy link
@nissa-seru nissa-seru commented Feb 9, 2025

Important

In Cline.ts, startTask() now appends environment details before the task message to improve task visibility.

  • Behavior:
    • In Cline.ts, startTask() now appends environment details before the task message in initiateTaskLoop() to ensure task visibility.
  • Misc:
    • Minor formatting changes in startTask() for consistency.

This description was created by Ellipsis for 0b38426. It will automatically update as commits are pushed.

Copy link
changeset-bot bot commented Feb 9, 2025

⚠️ No Changeset found

Latest commit: 96b984a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines +2768 to +2769
// prepend environment details as its own text block, separate from tool results
userContent.unshift({ type: "text", text: environmentDetails })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nissa-seru should we do this for every message like this or just the original task? Hope I'm not stepping on toes with this commit.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix - sorry about that. I believe it's correct as you currently have it, in that the environment details are sent along with each API request payload but not on each message in the chat history - I believe that's the purpose of that line. The abstraction is messy enough that a quick run in debug mode (exporting the task to check that the order is correct and that it's not being replicated for each message) may be best.

@mrubens
Copy link
Collaborator
mrubens commented Feb 9, 2025

I think this makes sense and seems like an improvement? Would be really nice to have some evals to run it through with different providers and models though. @cte do you think we could do something rough here?

@cte
Copy link
Collaborator
cte commented Feb 9, 2025

I think this makes sense and seems like an improvement? Would be really nice to have some evals to run it through with different providers and models though. @cte do you think we could do something rough here?

Yeah, I think I can set something quick up based on a WIP I have that uses Aider's benchmarks.

@hannesrudolph hannesrudolph moved this to To triage in Roo Code Roadmap Mar 5, 2025
@hannesrudolph hannesrudolph moved this from To triage to PR - Needs Approval in Roo Code Roadmap Mar 6, 2025
@mrubens mrubens moved this from PR [Unverified] to PR [Deferred] in Roo Code Roadmap Mar 10, 2025
@cte
Copy link
Collaborator
cte commented May 5, 2025

I think this is still worth eval'ing, but it also seems related to #3101.

@cte cte assigned cte and unassigned cte May 5, 2025
@nissa-seru nissa-seru closed this by deleting the head repository May 20, 2025
@hannesrudolph hannesrudolph moved this from New to Done in Roo Code Roadmap May 20, 2025
@hannesrudolph hannesrudolph moved this from Done to PR [Deferred] in Roo Code Roadmap May 20, 2025
@hannesrudolph hannesrudolph moved this from PR [Deferred] to Done in Roo Code Roadmap May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants
0