8000 Add seed config by SmartManoj · Pull Request #3217 · RooCodeInc/Roo-Code · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add seed config #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Add seed config #3217

wants to merge 21 commits into from

Conversation

SmartManoj
Copy link
@SmartManoj SmartManoj commented May 6, 2025

Context

Added seed config

Get in Touch

SmartManoj


Important

Add seed configuration to API functions, provider classes, and UI components, with localization updates for multiple languages.

  • Behavior:
    • Add modelSeed option to getModelParams() in index.ts.
    • Include seed in return object of getModelParams().
    • Add seed handling in BaseOpenAiCompatibleProvider, OpenAiNativeHandler, OpenAiHandler, and OpenRouterHandler.
  • UI Components:
    • Add SeedControl component in ApiOptions.tsx.
    • Update ApiOptions.test.tsx to mock VSCodeCheckbox.
  • Localization:
    • Add seed-related translations to settings.json in multiple locales (e.g., ca, de, en, es, fr, hi, it, ja, ko, nl, pl, pt-BR, ru, tr, vi, zh-CN, zh-TW).

This description was created by Ellipsis for 38bd25b. You can customize this summary. It will automatically update as commits are pushed.

Copy link
changeset-bot bot commented May 6, 2025

⚠️ No Changeset found

Latest commit: e0dfa43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels May 6, 2025
@SmartManoj
Copy link
Author

Is there any auto-translate script?

@mrubens
Copy link
Collaborator
mrubens commented May 6, 2025

Is there any auto-translate script?

There is a Translate mode that I ask to translate the changes into all languages

@mrubens
Copy link
Collaborator
mrubens commented May 6, 2025

Just tried this out locally and the seed doesn't seem to be saving. Any ideas?

Styling wise, do you mind making the input field look like the one here?
Screenshot 2025-05-06 at 8 21 48 AM

@SmartManoj SmartManoj marked this pull request as draft May 6, 2025 12:23
monotykamary pushed a commit to monotykamary/Roo-Code that referenced this pull request May 6, 2025
…inerules is currently a file (RooCodeInc#3217)

* create clinerules dir

* change default

* changeset

* md
@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap May 7, 2025
@SmartManoj
Copy link
Author

Current structure,
image

It is like the temperature field and will reduce the cognitive load.

It would be okay if "42" as the default value without the "Enter a seed value" field?

@SmartManoj
Copy link
Author

Just tried this out locally and the seed doesn't seem to be saving. Any ideas?

38bd25b

@SmartManoj SmartManoj marked this pull request as ready for review May 7, 2025 15:54
@SmartManoj
Copy link
Author

Before checked:
image

After checked:
image

@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap May 20, 2025
@hannesrudolph hannesrudolph moved this from PR [Needs Review] to TEMP in Roo Code Roadmap May 26, 2025
@daniel-lxs daniel-lxs moved this from TEMP to PR [Needs Review] in Roo Code Roadmap May 27, 2025
@daniel-lxs
Copy link
Collaborator

Hey @SmartManoj, Thank you for your contribution, We apologize we took so long to review your PR.

I think this is an interesting idea, It would be great if the input field was consistent with our other inputs.

Let me know if you'd like to discuss this further, hopefully we can get this PR over the finish line.

@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Draft / In Progress] in Roo Code Roadmap May 29, 2025
@daniel-lxs daniel-lxs marked this pull request as draft May 29, 2025 21:26
@daniel-lxs daniel-lxs moved this from PR [Draft / In Progress] to PR [Changes Requested] in Roo Code Roadmap May 29, 2025
@SmartManoj
Copy link
Author
SmartManoj commented May 30, 2025

Styling wise, do you mind making the input field look like the one here?
!image

Why the checkbox for this? Shouldn't it be like this?

image

Codepen


It is like the temperature field and will reduce the cognitive load.

image

@daniel-lxs
Copy link
Collaborator

This is how it looks for me right now:
image

This is probably what we want:
image

Since you mentioned using a slider, OpenRouter doesn't specify a minimum or maximum value:

Seed

Key: seed

Optional, integer

If specified, the inferencing will sample deterministically, such that repeated requests with the same seed and parameters should return the same result. Determinism is not guaranteed for some models.

Does it make sense to use a slider? What should we set as min and max values if we use a slider?

@SmartManoj
Copy link
Author
SmartManoj commented May 30, 2025

Since you mentioned using a slider

Nope, I meant it's like expanding the field when checked, like in temperature,

For temp, slider used; for seed, input field; remaining are the same, and both fields are together.


max values if we use a slider

No max limit


This is probably what we want:

Even for this, the checkbox is not needed. empty string, 0, and -1 should read all lines.

@daniel-lxs, would you provide a CodePen sample for seed?

@daniel-lxs
Copy link
Collaborator
daniel-lxs commented May 30, 2025

I think there's a misunderstanding.

I'm sharing that screenshot of the input because it is an example of how other inputs should look like to maintain consistency.

We want to copy that same style, not the functionality.

Hopefully this is not too confusing, let me know if you have any questions

@SmartManoj
Copy link
Author
SmartManoj commented May 30, 2025

@daniel-lxs, would you provide a CodePen sample for seed?

to check how it should look, actually, as there is no equivalent for "lines" text?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR - Changes Requested PR - Draft / In Progress size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: PR [Changes Requested]
Development

Successfully merging this pull request may close these issues.

3 participants
0