8000 [CI] Add GitHub Action to auto-close parent issues by SmartManoj · Pull Request #3661 · RooCodeInc/Roo-Code · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[CI] Add GitHub Action to auto-close parent issues #3661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

8000
Copy link
@SmartManoj SmartManoj commented May 16, 2025

Related GitHub Issue

#2211

Description

Add GitHub Action to auto-close parent issues when all child issues are closed

Test

https://github.com/SmartManoj/Roo-Code/actions/runs/15063558027/job/42343266065

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes


Important

Adds GitHub Action close-parent.yml to auto-close parent issues when all child issues are closed using GraphQL API.

  • Behavior:
    • Adds close-parent.yml GitHub Action to auto-close parent issues when all child issues are closed.
    • Triggers on closed issue events.
    • Uses GraphQL API to check sub-issue status and close parent if all are closed.
  • Implementation:
    • Retrieves issue and parent IDs using GraphQL queries.
    • Checks sub-issues' states and closes parent issue if all are closed.
    • Logs messages for no parent issue or if not all sub-issues are closed.

This description was created by Ellipsis for 265857a. You can customize this summary. It will automatically update as commits are pushed.

Copy link
changeset-bot bot commented May 16, 2025

⚠️ No Changeset found

Latest commit: d1c517a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels May 16, 2025
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
# Get the closed issue's number
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding set -e at the start of the run block to ensure the script exits immediately if a command fails. This would help avoid unpredictable behavior on API errors.

This comment was generated because it violated a code review rule: mrule_OR1S8PRRHcvbdFib.

repo=$(echo "${{ github.repository }}" | cut -d'/' -f2)

# Retrieve the issue ID
issue_id=$(gh api graphql -H "GraphQL-Features: sub_issues" -f query='
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be beneficial to add error handling for the gh api graphql calls. For example, verify that the response contains the expected data before proceeding, to handle API errors gracefully.

This comment was generated because it violated a code review rule: mrule_OR1S8PRRHcvbdFib.

@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap May 20, 2025
@hannesrudolph hannesrudolph moved this from PR [Needs Review] to TEMP in Roo Code Roadmap May 26, 2025
@daniel-lxs daniel-lxs moved this from TEMP to PR [Needs Review] in Roo Code Roadmap May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR - Needs Preliminary Review size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: PR [Needs Prelim Review]
Development

Successfully merging this pull request may close these issues.

2 participants
0