fix: respect user-configured terminal integration timeout #3886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The terminal integration timeout was being capped at the default value of 5 seconds due to a Math.min call in getShellIntegrationTimeout(), preventing users from setting longer timeouts. This caused shell integration to fail prematurely when initialization took longer than 5 seconds. This change removes the Math.min cap, allowing the user-configured timeout value to be respected. Fixes: cline#3885 Fixes: cline#3829 Regression from: cline#2820 Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>
cte
approved these changes
May 23, 2025
|
@cte please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Terminal integration timeout was being capped at 5 seconds regardless of user configuration, causing shell integration to fail prematurely when initialization took longer than 5 seconds.
Implementation
Removed the Math.min call in getShellIntegrationTimeout() that was capping the timeout at the default value of 5000ms, allowing the user-configured timeout value to be respected.
How to Test
Fixes #3885
Fixes #3829
Regression from #2820
Get in Touch
Discord: KJ7LNW
Important
Removed timeout cap in
getShellIntegrationTimeout()inBaseTerminal.tsto respect user-configured values, fixing premature shell integration failures.Math.mincall ingetShellIntegrationTimeout()inBaseTerminal.ts, allowing user-configured timeout values to be respected.This description was created by
for 0701a9d. You can customize this summary. It will automatically update as commits are pushed.