Adding support for custom VPC endpoints when using AWS Bedrock models #3947
+591
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed checkbox label to 'Use custom VPC endpoint' to match Cline - Fixed conditional rendering to show text field when checkbox is checked - Ensured placeholder text appears correctly - Maintained proper styling for consistency
- Added state variable to track checkbox selection - Fixed conditional rendering to show/hide text field based on checkbox state - Maintained proper styling and placeholder text
…ling - Fixed checkbox onChange handler to accept boolean directly instead of event object - Added unit tests to verify the behavior - Maintained proper styling and placeholder text
- Removed left margin from text field to align with checkbox - Maintained proper styling and placeholder text
- Added awsBedrockEndpointEnabled field to schema - Modified Bedrock provider to check both endpoint URL and enabled flag - Updated UI to preserve endpoint URL when checkbox is toggled - Maintained proper alignment with checkbox
… regenerate types
daniel-lxs
reviewed
May 30, 2025
webview-ui/src/components/settings/providers/Bedrock.tsx
Outdated
Hide resolved
|
Hey @kcwhite this looks good to me, could you solve the merge conflicts to hopefully get this merged? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #3492
Description
This PR adds support for custom VPC endpoints when using AWS Bedrock models. This feature is particularly important for corporate customers who need to keep all LLM transactions secure inside their firewall.
Implementation details:
Test Procedure
Unit Tests: Added tests for the Bedrock provider with custom endpoints
Manual Testing:
Verification:
pnpm testType of Change
srcor test files.Pre-Submission Checklist
npm run lint).console.log) has been removed.npm test).mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.Screenshots / Videos
I have included 2 screenshots
Documentation Updates
Additional Notes
This feature has been requested by several enterprise customers who need to use Roo Code with their secure AWS environments. It enables them to comply with their internal security policies while still leveraging the power of AWS Bedrock models through Roo Code.
Get in Touch
Discord: chuck_33620
Important
Adds support for custom VPC endpoints in AWS Bedrock models with UI and backend changes, ensuring backward compatibility and comprehensive test coverage.
awsBedrockEndpointandawsBedrockEndpointEnabledinProviderSettings.AwsBedrockHandlerinbedrock.tsto use custom endpoint if enabled.Bedrock.tsx.awsBedrockEndpointEnabled.bedrock-vpc-endpoint.test.tsto validate endpoint configuration logic.Bedrock.test.tsxto verify checkbox and text field behavior.ProviderSettingsinroo-code.d.tsandtypes.tsto include new fields for VPC endpoint configuration.This description was created by
for 617e68e. You can customize this summary. It will automatically update as commits are pushed.