fix: resolve provider switching issues and React Hook dependency warnings (fixes #3813, #3874) #3949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔧 Provider Switching Fixes: - Fix useSelectedModel hook with React useMemo for proper dependency management - Resolve Gemini and static providers model display issues when switching - Optimize apiModelId update logic to only apply to static providers - Ensure correct model values are displayed when switching between API providers 🚀 Performance Improvements: - Improve provider switching responsiveness - Fix React Hook dependency warnings in useSelectedModel Based on upstream v3.18.3 with proper Git merge
| setApiConfigurationField("apiModelId", selectedModelId) | ||
| if (selectedModelId && selectedProvider) { | ||
| // Only update apiModelId for static providers, not router providers | ||
| const staticProviders = [ |
There was a problem hiding this comment.
Consider moving the staticProviders array outside the effect (as a module-level constant) for clarity and to avoid re-creation on each render.
|
Why did elipsis redact the example of problematic code for the rest of us? |
|
Hey, @indiesewell Unfortunately I can't seem to find any repro steps to test your solution against. I'll be closing this temporarily. but feel free to reopen if you gather enough information about this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3813
Closes #3874
🎯 Overview
This PR fixes critical provider switching issues and resolves React Hook dependency warnings that were causing model display problems when switching between API providers.
🐛 Issues Fixed
⚡ Provider Switching Problems
🔧 React Hook Warnings
useSelectedModelhook missing proper dependency management🚀 Solutions Implemented
🎯 Smart Model Management
useSelectedModelHook: Added properuseMemowith correct dependenciesapiModelIdupdates to static providers📈 Performance Improvements
📁 Files Changed
webview-ui/src/components/ui/hooks/useSelectedModel.ts- Fixed React Hook with proper useMemo and dependencies🔍 Technical Details
Before (Problematic Code)
Important
Fixes provider switching issues and React Hook dependency warnings inuseSelectedModel.ts.
ApiOptions.tsxandApiOptions.tsx, updateapiModelIdonly for static providers whenselectedModelIdchanges.useSelectedModel.ts, useuseMemoforemptyRouterModelsandgetSelectedModelto manage dependencies properly.This description was created by
for e106947. You can customize this summary. It will automatically update as commits are pushed.