Add handling for external settings changes #3942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -824,6 +824,11 @@ export class ClineProvider extends EventEmitter<ClineProviderEvents> implements | |||
| this.contextProxy.setProviderSettings(providerSettings), | |||
| ]) | |||
|
|
|||
| // Notify CodeIndexManager about the settings change | |||
| if (this.codeIndexManager) { | |||
| await this.codeIndexManager.handleExternalSettingsChange() | |||
There was a problem hiding this comment.
Consider wrapping the call to codeIndexManager.handleExternalSettingsChange() in a try/catch (or handling its errors) so that a failure in reloading configuration doesn't break the profile activation flow.
mrubens
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add handling for external settings changes in code indexing, including default
qdrantUrland configuration reloads.ClineProvider.ts: NotifiesCodeIndexManagerof external settings changes viahandleExternalSettingsChange().config-manager.ts: Sets defaultqdrantUrltohttp://localhost:6333.manager.ts: AddshandleExternalSettingsChange()to reload configuration on settings update.CodeIndexSettings.tsx: Sets defaultcodebaseIndexQdrantUrltohttp://localhost:6333if undefined.This description was created by
for 5a4faeb. You can customize this summary. It will automatically update as commits are pushed.