8000 Fix: Wrongfully clearing input on autoApprove by Ruakij · Pull Request #3956 · RooCodeInc/Roo-Code · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: Wrongfully clearing input on autoApprove #3956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2025
Merged

Fix: Wrongfully clearing input on autoApprove #3956

merged 1 commit into from
May 25, 2025

Conversation

Ruakij
Copy link
@Ruakij Ruakij commented May 25, 2025 •
edited by ellipsis-dev bot
Loading

Related GitHub Issue

Closes: #3750

Description

This PR fixes a bug where the chat input field was cleared during auto-approval. (such as write_to_file), even if the user was typing. The fix removes the unconditional clearing of the input field and selected images in the autoApprove logic of ChatView.tsx, so user input is preserved during auto-approval.

Test Procedure

  • Manual test: Enable auto-approve for write tools, start a streaming write (e.g., write_to_file), type in the input while streaming, and verify the input is not cleared after auto-approval.
  • Verified that manual approval still clears the input as expected.

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • ✨ New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
      • < 8000 li class="task-list-item"> All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

No UI changes visible, so screenshots are not applicable.

Documentation Updates

  • No documentation updates are required.

Additional Notes

Get in Touch

Discord: ruakij

Important

Fixes input clearing bug during auto-approval in ChatView.tsx, preserving user input while maintaining manual approval behavior.

  • Behavior:
    • Fixes bug in ChatView.tsx where input field was cleared during auto-approval, preserving user input.
    • Manual approval still clears input as expected.
  • Code Changes:
    • Removes setInputValue("") and setSelectedImages([]) from autoApprove logic in ChatView.tsx.

This description was created by Ellipsis for 419d677. You can customize this summary. It will automatically update as commits are pushed.

@Ruakij Ruakij requested review from mrubens and cte as code owners May 25, 2025 10:02
@mrubens mrubens merged commit 503c758 into RooCodeInc:main May 25, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 25, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrubens mrubens mrubens approved these changes

@cte cte Awaiting requested review from cte cte is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Roo Code Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Persistent state of prompt input field not remaining populated
2 participants
@Ruakij @mrubens
0