Fix settings saving logic to ensure the saved settings are used #3976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xing in webviewMessageHandler
…anager is initialized
… and restart requirements
mrubens
approved these changes
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3964
Important
Fixes settings saving logic in
CodeIndexManagerto ensure saved settings are applied and used, with added tests for configuration change handling.webviewMessageHandlerto ensureCodeIndexManageruses saved settings and starts indexing if configured and enabled.CodeIndexConfigManagerto detect configuration changes that require a restart, including provider and model changes.CodeIndexManagerrestarts services if configuration changes require it.config-manager.test.tsto verify restart detection logic for various configuration changes.manager.test.tsto ensurehandleExternalSettingsChangeworks correctly when manager is uninitialized or initialized.service-factory.test.tsto verify embedder and vector store creation logic.CodeIndexSettings.tsxto handle provider and model selection changes, ensuring correct model ID is used for the selected provider.This description was created by
for 487e74b. You can customize this summary. It will automatically update as commits are pushed.