8000 Support boolean config values on the command line by rknop · Pull Request #8 · Roman-Supernova-PIT/snpit_utils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support boolean conf 8000 ig values on the command line #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 5, 2025
Merged

Conversation

rknop
Copy link
Collaborator
@rknop rknop commented Jun 5, 2025

No description provided.

@rknop rknop requested a review from a team as a code owner June 5, 2025 18:14
@rknop rknop requested a review from wmwv June 5, 2025 18:15
Copy link
@wmwv wmwv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can do the bool handling more simply by using the argparse built-in handling with argparse.BooleanOptionalAction.

https://docs.python.org/3/library/argparse.html#argparse.BooleanOptionalAction

Copy link
@wmwv wmwv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rknop rknop merged commit b5f1cb1 into main Jun 5, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 5, 2025
Support boolean config values on the command line b5f1cb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0