8000 Miscellaneous by jdisho · Pull Request #88 · StanfordBDHG/LLMonFHIR · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Miscellaneous #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 5, 2025
Merged

Miscellaneous #88

merged 7 commits into from
Apr 5, 2025

Conversation

jdisho
Copy link
Member
@jdisho jdisho commented Apr 4, 2025 •
edited
Loading

Miscellaneous

⚙️ Release Notes

  • System prompts: Now accepts an empty array, removing the default prompt: "You are ChatGPT, a large language model trained by OpenAI, based on the GPT architecture."
  • Removed patient description injection from the LLM context.
  • Survey Report JSON: After the study completion, the exported JSON contains a chronological timeline of events, including chat messages and survey tasks.
  • Added debugging support: The relevant FHIR resources used by the LLM, as well as all retrieved FHIR resources.
  • When the file is exported, it includes the study identifier.

survey_report_85dccf10-e0bd-4b68-9154-7eca719f2e45.json

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@jdisho jdisho added the enhancement New feature or request label Apr 4, 2025
@jdisho jdisho requested a review from PSchmiedmayer April 4, 2025 13:13
PSchmiedmayer
PSchmiedmayer approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member
@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; only had minimal comments about this. Thank you for all the work @jdisho! 🚀

@codecov Codecov
Copy link
codecov bot commented Apr 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 1.87793% with 209 lines in your changes missing coverage. Please review.

Project coverage is 32.07%. Comparing base (a7f1d72) to head (b2196cc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...erpretation/UserStudy/UserStudyChatViewModel.swift 0.00% 123 Missing ⚠️
...nterpretation/UserStudy/UserStudyChatToolbar.swift 0.00% 41 Missing ⚠️
...tion/UserStudy/UserStudyChatViewModel+Report.swift 0.00% 28 Missing ⚠️
...LMonFHIR/FHIRInterpretation 8000 /UserStudy/Survey.swift 0.00% 12 Missing ⚠️
...IRInterpretation/UserStudy/UserStudyChatView.swift 0.00% 3 Missing ⚠️
...nterpretation/UserStudy/UserStudyWelcomeView.swift 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   33.91%   32.07%   -1.84%     
==========================================
  Files          42       43       +1     
  Lines        2321     2439     +118     
==========================================
- Hits          787      782       -5     
- Misses       1534     1657     +123
Files with missing lines Coverage Δ
...pleResources/FHIRMultipleResourceInterpreter.swift 46.40% <100.00%> (+0.40%) ⬆️
LLMonFHIR/FHIRInterpretationModule.swift 100.00% <100.00%> (ø)
LLMonFHIR/Helper/FHIRStore+Interpretation.swift 53.78% <ø> (+1.64%) ⬆️
...nterpretation/UserStudy/UserStudyWelcomeView.swift 2.50% <0.00%> (-0.02%) ⬇️
...IRInterpretation/UserStudy/UserStudyChatView.swift 0.00% <0.00%> (ø)
...LMonFHIR/FHIRInterpretation/UserStudy/Survey.swift 0.00% <0.00%> (ø)
...tion/UserStudy/UserStudyChatViewModel+Report.swift 0.00% <0.00%> (ø)
...nterpretation/UserStudy/UserStudyChatToolbar.swift 0.00% <0.00%> (ø)
...erpretation/UserStudy/UserStudyChatViewModel.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7f1d72...b2196cc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jdisho
Copy link
Member Author
jdisho commented Apr 5, 2025

I realized that VersionedResource in SpeziFHIR.FHIRResource is already public, which makes encoding much easier. We don't need to decode and encode the jsonDescription anymore like I was doing in FHIRResource+Encodable.

@jdisho jdisho merged commit e3372c4 into main Apr 5, 2025
11 of 15 checks passed
@jdisho jdisho deleted the miscellaneous branch April 5, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PSchmiedmayer PSchmiedmayer PSchmiedmayer approved these changes

Assignees

@jdisho jdisho

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdisho @PSchmiedmayer
0