8000 Update SpeziAccessGuard by jdisho · Pull Request #98 · StanfordBDHG/LLMonFHIR · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update SpeziAccessGuard #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2025
Merged
8000

Update SpeziAccessGuard #98

merged 2 commits into from
May 5, 2025

Conversation

jdisho
Copy link
Member
@jdisho jdisho commented May 4, 2025

Update SpeziAccessGuard

♻️ Current situation & Problem

The problem with the previous approach was that the EnterCodeView was added as an overlay of the guarded view, which means that when the EnterCodeView is shown, all the work happening onAppear of the guarded view will be executed even though the view is not visible.

⚙️ Release Notes

StanfordSpezi/SpeziAccessGuard#29
StanfordSpezi/SpeziAccessGuard#30

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@jdisho jdisho added the enhancement New feature or request label May 4, 2025
@jdisho jdisho requested a review from PSchmiedmayer May 4, 2025 07:39
@jdisho jdisho self-assigned this May 4, 2025
@codecov Codecov
Copy link
codecov bot commented May 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.43%. Comparing base (d859ea7) to head (ddaddcf).
Report is 1 commits behind head on rework-survey.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           rework-survey      #98      +/-   ##
=================================================
+ Coverage          23.31%   23.43%   +0.13%     
=================================================
  Files                 57       57              
  Lines                618      619       +1     
=================================================
+ Hits                 144      145       +1     
  Misses               474      474
Files with missing lines Coverage Δ
...nterpretation/UserStudy/UserStudyWelcomeView.swift 2.50% <ø> (ø)
LLMonFHIR/LLMonFHIRDelegate.swift 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d859ea7...ddaddcf. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PSchmiedmayer PSchmiedmayer changed the base branch from main to rework-survey May 5, 2025 23:18
PSchmiedmayer
PSchmiedmayer approved these changes May 5, 2025
View reviewed changes
Copy link
Member
@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thank you!

@PSchmiedmayer PSchmiedmayer deleted the bump-access-guard branch May 5, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PSchmiedmayer PSchmiedmayer PSchmiedmayer approved these changes

Assignees

@jdisho jdisho

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdisho @PSchmiedmayer
0